fix: The Profiler logger should be marked as "initialized" as soon as the file is created. (#3015)

Author: tippmar-nr

.github/codeql/codeql-config.yml

@@ -1,2 +1,2 @@
 paths:
-    -'src' # this is the only path that needs to be scanned
+    - src

.github/codeql/codql-config.yml

@@ -57,7 +57,10 @@ jobs:
         languages: csharp
         config-file: ./.github/codeql/codeql-config.yml
 
-    # build is not required for .NET projects
+    - name: Build .NET Agent Solution
+      run: |
+        dotnet build ${{ env.fullagent_solution_path }}
+      shell: powershell
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3.28.10

.github/workflows/codeql.yml

@@ -13,7 +13,7 @@
   </Target>
 
   <ItemGroup>
-    <PackageReference Include="NewRelic.Agent.Internal.Profiler" Version="10.37.0.7"/>
+    <PackageReference Include="NewRelic.Agent.Internal.Profiler" Version="10.37.0.19"/>
   </ItemGroup>
 
 </Project>

src/Agent/NewRelic/Home/Home.csproj

@@ -222,15 +222,16 @@ namespace NewRelic { namespace Profiler {
                     configFailed = true;
                 }
 
-                // ...then we initialize the log
+                // ...then we initialize the log file 
                 InitializeLogging();
 
                 // If we failed to load the config file, try again. Not because we expect it
                 // to succeed, but because we want to log the error. We couldn't do that the
                 // first time because the logger hadn't been initialized yet
                 if (configFailed)
                 {
-                    configuration = InitializeConfigAndSetLogLevel();
+                    nrlog::StdLog.SetInitalized(); // Ensure the logger is marked as initialized
+                    configuration = InitializeConfigAndSetLogLevel(); // this will throw an exception that we want to log
                 }
 
                 LogTrace(_productName);
@@ -277,7 +278,7 @@ namespace NewRelic { namespace Profiler {
                 return S_OK;
             }
             catch (...) {
-                LogError(L"An exception was thrown while initializing the profiler.");
+                LogError(L"An exception was thrown while initializing the profiler. The profiler will be detached now.");
                 return CORPROF_E_PROFILER_CANCEL_ACTIVATION;
             }
         }