fix: Fix distributed tracing handling of empty string fetch parameter

[patrickhousley]

Fixing an issue with distributed tracing that would result in an exception within the agent when fetch is called with an empty string as the first parameter.

Overview

Fixing an issue with distributed tracing that would result in an exception within the agent when fetch is called with an empty string as the first parameter.

Related Issue(s)

https://issues.newrelic.com/browse/NR-142512

Testing

[github-actions]

Last ran on August 15, 2023 13:34:02 CDT
Checking merge of (58a0683) into main (4bb3e81)

[codecov]

Codecov Report

Merging #640 (3a16423) into main (ada8ad2) will increase coverage by 1.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   68.68%   69.94%   +1.25%     
==========================================
  Files         134      134              
  Lines        6004     5995       -9     
  Branches     1144     1141       -3     
==========================================
+ Hits         4124     4193      +69     
+ Misses       1544     1487      -57     
+ Partials      336      315      -21     

Flag	Coverage Δ
jest	76.84% <100.00%> (+0.83%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...rc/features/ajax/instrument/distributed-tracing.js	69.91% <ø> (+62.15%)	⬆️
src/features/ajax/instrument/index.js	47.20% <ø> (-0.06%)	⬇️
src/common/deny-list/deny-list.js	88.88% <100.00%> (+2.77%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Asset Size Report

Merging this pull request will result in the following CDN asset size changes:

Asset Name	Previous Size	New Size	Diff
nr-loader-spa.min	69.94 kB / 19.05 kB (gzip)	69.9 kB / 19.05 kB (gzip)	-0.05% / +0.03% (gzip)
nr-loader-full.min	66.63 kB / 18.18 kB (gzip)	66.6 kB / 18.19 kB (gzip)	-0.06% / +0.04% (gzip)
nr-loader-rum.min	38.3 kB / 10.92 kB (gzip)	38.3 kB / 10.92 kB (gzip)	-0% / -0% (gzip)
nr-loader-spa-polyfills.min	191.62 kB / 43.33 kB (gzip)	191.56 kB / 43.33 kB (gzip)	-0.03% / +0.01% (gzip)
nr-loader-full-polyfills.min	187.34 kB / 42.35 kB (gzip)	187.28 kB / 42.35 kB (gzip)	-0.03% / +0.01% (gzip)
nr-loader-rum-polyfills.min	155.01 kB / 34.41 kB (gzip)	155.01 kB / 34.41 kB (gzip)	-0% / -0% (gzip)
nr-loader-worker.min	68.1 kB / 19.05 kB (gzip)	68.1 kB / 19.09 kB (gzip)	-0.01% / +0.18% (gzip)

Merging this pull request will result in the following NPM package consumer size changes:

Asset Name	Previous Size	New Size	Diff
Browser Agent	51.33 kB / 17.1 kB (gzip)	51.73 kB / 17.2 kB (gzip)	+0.78% / +0.55% (gzip)
Custom Lite Agent	28.14 kB / 9.92 kB (gzip)	28.65 kB / 10.04 kB (gzip)	+1.8% / +1.23% (gzip)
Custom Pro Agent	44.81 kB / 15.09 kB (gzip)	45.24 kB / 15.2 kB (gzip)	+0.95% / +0.74% (gzip)
Custom SPA Agent	51.21 kB / 17.06 kB (gzip)	51.61 kB / 17.15 kB (gzip)	+0.78% / +0.5% (gzip)
Worker Agent	306.04 kB / 94.68 kB (gzip)	306.73 kB / 94.87 kB (gzip)	+0.22% / +0.2% (gzip)

Other Standard CDN Assets

Released Assets

Asset Name	Asset Size
recorder.js	477.18 kB / 84.04 kB (gzip)
compressor.js	88.03 kB / 20.94 kB (gzip)
src_common_session_session-entity_js.js	82.63 kB / 17.18 kB (gzip)
spa-aggregate.js	68.14 kB / 14.97 kB (gzip)
jserrors-aggregate.js	47.44 kB / 11.44 kB (gzip)
session_trace-aggregate.js	37.56 kB / 10.28 kB (gzip)
src_common_harvest_harvest_js-src_features_utils_aggregate-base_js.js	33.1 kB / 8.2 kB (gzip)
metrics-aggregate.js	31.82 kB / 7.88 kB (gzip)
page_view_timing-aggregate.js	30.35 kB / 8.5 kB (gzip)
page_view_event-aggregate.js	27.12 kB / 7.39 kB (gzip)
session_replay-aggregate.js	21.67 kB / 6.13 kB (gzip)
page_action-aggregate.js	20.94 kB / 5.61 kB (gzip)
ajax-aggregate.js	17.6 kB / 4.37 kB (gzip)
src_common_harvest_harvest-scheduler_js-src_common_serialize_bel-serializer_js.js	16.7 kB / 5.05 kB (gzip)
src_common_constants_shared-channel_js-src_common_harvest_harvest-scheduler_js.js	14 kB / 4.37 kB (gzip)
async-api.js	13.15 kB / 3.6 kB (gzip)
session-manager.js	6.8 kB / 1.73 kB (gzip)
lazy-feature-loader.js	6.78 kB / 1.28 kB (gzip)

Built Assets

Asset Name	Asset Size
recorder.js	477.18 kB / 84.04 kB (gzip)
compressor.js	88.03 kB / 20.94 kB (gzip)
src_common_session_session-entity_js.js	82.63 kB / 17.18 kB (gzip)
spa-aggregate.js	68.13 kB / 14.97 kB (gzip)
jserrors-aggregate.js	47.44 kB / 11.44 kB (gzip)
session_trace-aggregate.js	37.56 kB / 10.28 kB (gzip)
src_common_harvest_harvest_js-src_features_utils_aggregate-base_js.js	33.1 kB / 8.2 kB (gzip)
metrics-aggregate.js	31.82 kB / 7.88 kB (gzip)
page_view_timing-aggregate.js	30.35 kB / 8.5 kB (gzip)
page_view_event-aggregate.js	27.12 kB / 7.39 kB (gzip)
session_replay-aggregate.js	21.67 kB / 6.13 kB (gzip)
page_action-aggregate.js	20.94 kB / 5.61 kB (gzip)
ajax-aggregate.js	17.6 kB / 4.37 kB (gzip)
src_common_harvest_harvest-scheduler_js-src_common_serialize_bel-serializer_js.js	16.7 kB / 5.05 kB (gzip)
src_common_constants_shared-channel_js-src_common_harvest_harvest-scheduler_js.js	14 kB / 4.37 kB (gzip)
async-api.js	13.15 kB / 3.6 kB (gzip)
session-manager.js	6.8 kB / 1.73 kB (gzip)
lazy-feature-loader.js	6.78 kB / 1.28 kB (gzip)

Other Polyfill CDN Assets

Released Assets

Asset Name	Asset Size
recorder-es5.js	479.97 kB / 84.16 kB (gzip)
nr-polyfills.min.js	97.37 kB / 19.93 kB (gzip)
compressor-es5.js	88.78 kB / 20.95 kB (gzip)
src_common_session_session-entity_js-es5.js	88.25 kB / 18.61 kB (gzip)
spa-aggregate-es5.js	77.28 kB / 17.17 kB (gzip)
session_trace-aggregate-es5.js	74.42 kB / 16.09 kB (gzip)
session_replay-aggregate-es5.js	41.09 kB / 11.12 kB (gzip)
src_common_harvest_harvest_js-src_features_utils_aggregate-base_js-es5.js	38.96 kB / 9.62 kB (gzip)
page_view_timing-aggregate-es5.js	37.29 kB / 10.23 kB (gzip)
jserrors-aggregate-es5.js	36.63 kB / 8.5 kB (gzip)
page_view_event-aggregate-es5.js	30.17 kB / 8.31 kB (gzip)
ajax-aggregate-es5.js	25.32 kB / 6.3 kB (gzip)
metrics-aggregate-es5.js	18.07 kB / 4.31 kB (gzip)
src_common_harvest_harvest-scheduler_js-es5.js	16.94 kB / 5.12 kB (gzip)
async-api-es5.js	15.28 kB / 4.38 kB (gzip)
page_action-aggregate-es5.js	9.38 kB / 2.45 kB (gzip)
session-manager-es5.js	7.33 kB / 1.81 kB (gzip)
lazy-feature-loader-es5.js	6.8 kB / 1.24 kB (gzip)

Built Assets

Asset Name	Asset Size
recorder-es5.js	479.97 kB / 84.16 kB (gzip)
nr-polyfills.min.js	97.37 kB / 19.93 kB (gzip)
compressor-es5.js	88.78 kB / 20.95 kB (gzip)
src_common_session_session-entity_js-es5.js	88.25 kB / 18.61 kB (gzip)
spa-aggregate-es5.js	77.25 kB / 17.16 kB (gzip)
session_trace-aggregate-es5.js	74.42 kB / 16.09 kB (gzip)
session_replay-aggregate-es5.js	41.09 kB / 11.12 kB (gzip)
src_common_harvest_harvest_js-src_features_utils_aggregate-base_js-es5.js	38.96 kB / 9.62 kB (gzip)
page_view_timing-aggregate-es5.js	37.29 kB / 10.23 kB (gzip)
jserrors-aggregate-es5.js	36.63 kB / 8.5 kB (gzip)
page_view_event-aggregate-es5.js	30.17 kB / 8.31 kB (gzip)
ajax-aggregate-es5.js	25.29 kB / 6.29 kB (gzip)
metrics-aggregate-es5.js	18.07 kB / 4.31 kB (gzip)
src_common_harvest_harvest-scheduler_js-es5.js	16.94 kB / 5.12 kB (gzip)
async-api-es5.js	15.28 kB / 4.38 kB (gzip)
page_action-aggregate-es5.js	9.38 kB / 2.45 kB (gzip)
session-manager-es5.js	7.33 kB / 1.81 kB (gzip)
lazy-feature-loader-es5.js	6.8 kB / 1.24 kB (gzip)