fix: Typo in type declarations #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhousley
force-pushed
the
fix-types
branch
from
b620bb7 to
59d2031
Compare
|
@villelahdenvuo This should fix the type errors you are having. |
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 134 134
Lines 6004 6004
Branches 1144 1144
=======================================
Hits 4124 4124
Misses 1544 1544
Partials 336 336
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
|
Nice to see tests added. 😃 |
1 task
metal-messiah
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing typos made in the browser and micro agent API declarations. This includes adding internal test cases for those types to ensure this issue does not happen again.
Overview
This fixes typos made in the agent API type declarations and adds tests for those types.
Related Issue(s)
#613 (comment)
Testing
Run `npm run npm:build:types && npm run test:types"