fix: Remove undefined agentRuntime in Session Trace (#1227)

Author: cwli24

src/features/session_trace/aggregate/trace/storage.js

@@ -40,7 +40,7 @@ export class TraceStorage {
   storeSTN (stn) {
     if (this.parent.blocked) return
     if (this.nodeCount >= MAX_NODES_PER_HARVEST) { // limit the amount of pending data awaiting next harvest
-      if (this.parent.agentRuntime.session.state.sessionTraceMode !== MODE.ERROR) return
+      if (this.parent.mode !== MODE.ERROR) return
       const openedSpace = this.trimSTNs(ERROR_MODE_SECONDS_WINDOW) // but maybe we could make some space by discarding irrelevant nodes if we're in sessioned Error mode
       if (openedSpace === 0) return
     }

tests/components/session_trace/aggregate.test.js

@@ -1,6 +1,7 @@
 import { Instrument as SessionTrace } from '../../../src/features/session_trace/instrument'
 import { setupAgent } from '../setup-agent'
 import { MODE } from '../../../src/common/session/constants'
+import { MAX_NODES_PER_HARVEST } from '../../../src/features/session_trace/constants'
 
 let mainAgent
 
@@ -103,3 +104,22 @@ test('tracks previously stored events and processes them once per occurrence', d
     done()
   }, 100)
 })
+
+test('when max nodes per harvest is reached, no node is further added in FULL mode', () => {
+  sessionTraceAggregate.traceStorage.nodeCount = MAX_NODES_PER_HARVEST
+  sessionTraceAggregate.mode = MODE.FULL
+
+  sessionTraceAggregate.traceStorage.storeSTN({ n: 'someNode', s: 123 })
+  expect(sessionTraceAggregate.traceStorage.nodeCount).toEqual(MAX_NODES_PER_HARVEST)
+  expect(Object.keys(sessionTraceAggregate.traceStorage.trace).length).toEqual(0)
+})
+
+test('when max nodes per harvest is reached, node is still added in ERROR mode', () => {
+  sessionTraceAggregate.traceStorage.nodeCount = MAX_NODES_PER_HARVEST
+  sessionTraceAggregate.mode = MODE.ERROR
+  jest.spyOn(sessionTraceAggregate.traceStorage, 'trimSTNs').mockReturnValue(MAX_NODES_PER_HARVEST)
+
+  sessionTraceAggregate.traceStorage.storeSTN({ n: 'someNode', s: 123 })
+  expect(sessionTraceAggregate.traceStorage.nodeCount).toEqual(MAX_NODES_PER_HARVEST + 1)
+  expect(Object.keys(sessionTraceAggregate.traceStorage.trace).length).toEqual(1)
+})