feat: Remove supportsSendBeacon runtime property (#1224)

Author: ellisong

src/common/constants/__mocks__/runtime.js

@@ -5,6 +5,5 @@ export const initialLocation = '' + globalScope?.location
 export const isiOS = false
 export const iOSBelow16 = false
 export const ffVersion = 0
-export const supportsSendBeacon = true
 
 export const originTime = Date.now()

src/common/constants/runtime.js

@@ -72,8 +72,6 @@ export const ffVersion = (() => {
   return 0
 })()
 
-export const supportsSendBeacon = !!globalScope.navigator?.sendBeacon
-
 /**
  * Represents the absolute timestamp in milliseconds that the page was loaded
  * according to the browser's local clock.

src/common/util/submit-data.js

@@ -4,7 +4,7 @@
  * @license Apache-2.0
  */
 
-import { isBrowserScope, supportsSendBeacon } from '../constants/runtime'
+import { isBrowserScope } from '../constants/runtime'
 
 /**
  * @typedef {xhr|beacon} NetworkMethods
@@ -17,7 +17,7 @@ import { isBrowserScope, supportsSendBeacon } from '../constants/runtime'
  * a final harvest within the agent.
  */
 export function getSubmitMethod ({ isFinalHarvest = false } = {}) {
-  return isFinalHarvest && isBrowserScope && supportsSendBeacon
+  return isFinalHarvest && isBrowserScope
     // Use sendBeacon for final harvest
     ? beacon
     // If not final harvest, or not browserScope, always use xhr post

tests/unit/common/constants/runtime.test.js

@@ -155,22 +155,3 @@ test.each([
   expect(runtime.ffVersion).toEqual(expected)
   delete global.window
 })
-
-test('should set supportsSendBeacon to false', async () => {
-  // Ensure we don't have a sendBeacon function
-  delete global.navigator.sendBeacon
-
-  const runtime = await import('../../../../src/common/constants/runtime')
-
-  expect(runtime.supportsSendBeacon).toEqual(false)
-})
-
-test('should set supportsSendBeacon to true', async () => {
-  global.navigator.sendBeacon = jest.fn()
-  global.window = { navigator: global.navigator, document: true }
-
-  const runtime = await import('../../../../src/common/constants/runtime')
-
-  expect(runtime.supportsSendBeacon).toEqual(true)
-  delete global.window
-})

tests/unit/common/util/submit-data.test.js

@@ -19,21 +19,12 @@ afterEach(() => {
 describe('getSubmitMethod', () => {
   test('should use xhr for final harvest when isBrowserScope is false', () => {
     jest.replaceProperty(runtimeModule, 'isBrowserScope', false)
-    jest.replaceProperty(runtimeModule, 'supportsSendBeacon', true)
 
     expect(submitData.getSubmitMethod({ isFinalHarvest: true })).toEqual(submitData.xhr)
   })
 
-  test('should use xhr for final harvest when supportsSendBeacon is false', () => {
+  test('should use beacon for final harvest when isBrowserScope is true', () => {
     jest.replaceProperty(runtimeModule, 'isBrowserScope', true)
-    jest.replaceProperty(runtimeModule, 'supportsSendBeacon', false)
-
-    expect(submitData.getSubmitMethod({ isFinalHarvest: true })).toEqual(submitData.xhr)
-  })
-
-  test('should use beacon for final harvest when isBrowserScope and supportsSendBeacon is true', () => {
-    jest.replaceProperty(runtimeModule, 'isBrowserScope', true)
-    jest.replaceProperty(runtimeModule, 'supportsSendBeacon', true)
 
     expect(submitData.getSubmitMethod({ isFinalHarvest: true })).toEqual(submitData.beacon)
   })
@@ -42,14 +33,12 @@ describe('getSubmitMethod', () => {
     null, undefined, false
   ])('should use xhr when final harvest is %s', (isFinalHarvest) => {
     jest.replaceProperty(runtimeModule, 'isBrowserScope', true)
-    jest.replaceProperty(runtimeModule, 'supportsSendBeacon', true)
 
     expect(submitData.getSubmitMethod({ isFinalHarvest })).toEqual(submitData.xhr)
   })
 
   test('should use xhr when opts is undefined', () => {
     jest.replaceProperty(runtimeModule, 'isBrowserScope', true)
-    jest.replaceProperty(runtimeModule, 'supportsSendBeacon', true)
 
     expect(submitData.getSubmitMethod()).toEqual(submitData.xhr)
   })