Skip to content

Commit 229b8ed

Browse files
fix: Ensure runtime is preserved for late-configuration cases (#538)
1 parent 68280ca commit 229b8ed

File tree

3 files changed

+29
-15
lines changed

3 files changed

+29
-15
lines changed

src/features/utils/feature-base.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ export class FeatureBase {
4444
info: {
4545
...gosCDN().info,
4646
jsAttributes
47-
}
47+
},
48+
runtime: getRuntime(this.agentIdentifier)
4849
})
4950
}
5051
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
2+
const testDriver = require('../../../tools/jil/index')
3+
let notSafariWithSeleniumBug = testDriver.Matcher.withFeature('notSafariWithSeleniumBug')
4+
5+
testDriver.test(`Session object exists when config is set after loader`, notSafariWithSeleniumBug, function (t, browser, router) {
6+
let url = router.assetURL('custom-attribute-race-condition.html', {init: {jserrors: {enabled: true, harvestTimeSeconds: 5}}})
7+
8+
let loadPromise = browser.get(url)
9+
let rumPromise = router.expectRum()
10+
var errorsPromise = router.expectErrors()
11+
12+
Promise.all([rumPromise, loadPromise])
13+
.then(() => {
14+
var domPromise = browser.get(url) // forces harvest
15+
return Promise.all([errorsPromise, domPromise])
16+
})
17+
.then(([{ request: {query} }]) => {
18+
t.ok(query.s !== '0', 'Session ID exists')
19+
t.end()
20+
})
21+
.catch(fail)
22+
23+
function fail (e) {
24+
t.error(e)
25+
t.end()
26+
}
27+
})

tools/browsers-lists/browsers-supported.json

-14
Original file line numberDiff line numberDiff line change
@@ -123,20 +123,6 @@
123123
}
124124
],
125125
"ios": [
126-
{
127-
"browserName": "Safari",
128-
"platformName": "iOS",
129-
"platform": "iOS",
130-
"version": "15.0",
131-
"device": "iPhone 7 Plus",
132-
"appium:deviceName": "iPhone 7 Plus Simulator",
133-
"appium:platformVersion": "15.0",
134-
"appium:automationName": "XCUITest",
135-
"sauce:options": {
136-
"appiumVersion": "1.22.3"
137-
},
138-
"acceptInsecureCerts": false
139-
},
140126
{
141127
"browserName": "Safari",
142128
"platformName": "iOS",

0 commit comments

Comments
 (0)