Skip to content

shutdown ignored in ssl_tls_accept #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt335672 opened this issue May 9, 2025 · 1 comment
Open

shutdown ignored in ssl_tls_accept #3525

matt335672 opened this issue May 9, 2025 · 1 comment
Labels

Comments

@matt335672
Copy link
Member

xrdp version

0.10.x

Detailed xrdp version, build options

xrdp 0.10.3
  A Remote Desktop Protocol Server.
  Copyright (C) 2004-2025 Jay Sorg, Neutrino Labs, and all contributors.
  See https://github.com/neutrinolabs/xrdp for more information.

  Configure options:
      --disable-devel-all
      --enable-fuse
      --enable-pixman
      --enable-ipv6
      --enable-painter
      --enable-jpeg
      --with-imlib2
      --enable-vsock
      --with-freetype2
      --enable-ibus
      --enable-x264
      --enable-openh264
      --enable-utmp
      --with-libpcsclite
      --enable-neutrinordp
      CC=gcc
      CFLAGS=-g -fvar-tracking -Wl,-z,now -Wno-error=deprecated-declarations

  Compiled with OpenSSL 3.0.13 30 Jan 2024

Operating system & version

Ubuntu 24.04

Installation method

git clone & make install

Which backend do you use?

N/A

What desktop environment do you use?

N/A

Environment xrdp running on

Nested VM

What's your client?

Remmina

Area(s) with issue?

Other

Steps to reproduce

  1. sudo systemctl start xrdp
  2. Connect from Remmina:-

Image

  1. Debugger shows child xrdp in ssl_tls_accept():-
(gdb) where
#0  0x000072b63031b494 in __GI___poll (fds=fds@entry=0x7ffddfc18950, nfds=nfds@entry=1, timeout=timeout@entry=100)
    at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x000072b630b2081a in poll (__timeout=<optimized out>, __nfds=1, __fds=0x7ffddfc18950)
    at /usr/include/x86_64-linux-gnu/bits/poll2.h:39
#2  g_sck_can_recv (sck=<optimized out>, millis=millis@entry=100) at os_calls.c:1605
#3  0x000072b630b24ba0 in ssl_tls_accept (self=0x5d19ee7ef300, ssl_protocols=ssl_protocols@entry=369098752, 
    tls_ciphers=tls_ciphers@entry=0x0) at ssl_calls.c:1210
#4  0x000072b630b27d81 in trans_set_tls_mode (self=0x5d19ee7eb460, key=<optimized out>, cert=<optimized out>, 
    ssl_protocols=369098752, tls_ciphers=0x0) at trans.c:1056
#5  0x000072b630af737a in xrdp_sec_incoming (self=0x5d19ee7ed2e0) at xrdp_sec.c:2525
#6  0x000072b630af2cbc in xrdp_rdp_incoming (self=0x5d19ee7eb680) at xrdp_rdp.c:943
#7  0x000072b630ad7d9d in libxrdp_process_incoming (session=<optimized out>) at libxrdp.c:87
#8  0x00005d19cfb976a8 in xrdp_process_main_loop (self=self@entry=0x5d19ee7e45f0) at xrdp_process.c:248
#9  0x00005d19cfb8a8bb in xrdp_process_run (in_val=0x0) at xrdp_listen.c:153
#10 xrdp_listen_fork (server_trans=0x5d19ee7eb460, self=0x5d19ee7e48c0) at xrdp_listen.c:714
#11 xrdp_listen_main_loop (self=0x5d19ee7e48c0) at xrdp_listen.c:888
#12 0x00005d19cfb81adf in main (argc=<optimized out>, argv=<optimized out>) at xrdp.c:778
  1. sudo systemctl stop xrdp hangs, as child xrdp ignores signal.

✔️ Expected Behavior

systemctl stop completes.

❌ Actual Behavior

systemctl stop hangs.

Anything else?

No response

@matt335672 matt335672 added the bug label May 9, 2025
@matt335672
Copy link
Member Author

I'll look at this the week after next, unless someone else picks it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant