Skip to content

Commit 2f2ee83

Browse files
committed
chore: Update README.md
1 parent 0ce990c commit 2f2ee83

File tree

3 files changed

+28
-24
lines changed

3 files changed

+28
-24
lines changed

CONTRIBUTING.md

+6-13
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
7676
that relates to your submission. You don't want to duplicate effort.
7777
<!-- 1. Please sign our [Contributor License Agreement (CLA)](#cla) before sending PRs.
7878
We cannot accept code without this. -->
79-
1. Fork the nestjs/nest repo.
79+
1. Fork the nestjs/terminus repo.
8080
1. Make your changes in a new git branch:
8181

8282
```shell
@@ -85,7 +85,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
8585

8686
1. Create your patch, **including appropriate test cases**.
8787
1. Follow our [Coding Rules](#rules).
88-
1. Run the full Nest test suite, as described in the [developer documentation][dev-doc],
88+
1. Run the full Nest test suite, as described in the README.md,
8989
and ensure that all tests pass.
9090
1. Commit your changes using a descriptive commit message that follows our
9191
[commit message conventions](#commit). Adherence to these conventions
@@ -102,7 +102,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
102102
git push origin my-fix-branch
103103
```
104104

105-
1. In GitHub, send a pull request to `nestjs:master`.
105+
1. In GitHub, send a pull request to `nestjs/terminus:master`.
106106
* If we suggest changes then:
107107
* Make the required updates.
108108
* Re-run the Nest test suites to ensure tests are still passing.
@@ -148,12 +148,6 @@ from the main (upstream) repository:
148148
To ensure consistency throughout the source code, keep these rules in mind as you are working:
149149
150150
* All features or bug fixes **must be tested** by one or more specs (unit-tests).
151-
<!--
152-
// We're working on auto-documentation.
153-
* All public API methods **must be documented**. (Details TBC). -->
154-
* We follow [Google's JavaScript Style Guide][js-style-guide], but wrap all code at
155-
**100 characters**. An automated formatter is available, see
156-
[DEVELOPER.md](docs/DEVELOPER.md#clang-format).
157151
158152
## <a name="commit"></a> Commit Message Guidelines
159153
@@ -180,13 +174,13 @@ to read on GitHub as well as in various git tools.
180174
181175
Footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.
182176
183-
Samples: (even more [samples](https://github.com/nestjs/nest/commits/master))
177+
Samples: (even more [samples](https://github.com/nestjs/terminus/commits/master))
184178
185179
```
186-
docs(changelog) update change log to beta.5
180+
docs: update change log to beta.5
187181
```
188182
```
189-
fix(@nestjs/core) need to depend on latest rxjs and zone.js
183+
fix: need to depend on latest rxjs and zone.js
190184
191185
The version in our package.json gets copied to the one we publish, and users need the latest of these.
192186
```
@@ -242,7 +236,6 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
242236
<!-- [coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md -->
243237
[commit-message-format]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
244238
[corporate-cla]: http://code.google.com/legal/corporate-cla-v1.0.html
245-
[dev-doc]: https://github.com/nestjs/nest/blob/master/docs/DEVELOPER.md
246239
[github]: https://github.com/nestjs/nest
247240
[discord]: https://discord.gg/nestjs
248241
[individual-cla]: http://code.google.com/legal/individual-cla-v1.0.html

README.md

+18-7
Original file line numberDiff line numberDiff line change
@@ -107,25 +107,36 @@ Setup the development environment by following these instructions:
107107
2. Install the dependencies
108108

109109
```bash
110-
npm install
110+
pnpm i
111+
pnpm dev
112+
```
113+
114+
In order to test the library against a sample, simply go to a sample and run
115+
`pnpm start:dev`
111116

112-
# To rebuild the project, run
113-
npm run build
117+
```typescript
118+
cd sample/000-dogs-app
119+
pnpm start:dev
114120
```
115121

122+
> [!NOTE]
123+
> Once the library is rebuilt, the `pnpm start:dev` within a sample
124+
> needs to be restarted in order to pick up the changes.
125+
116126
### Test
117127

118128
For unit testing run the following command:
119129

120130
```bash
121-
npm run test
131+
pnpm test
122132
```
123133

124-
For e2e testing, make sure you have docker installed
134+
For e2e testing, a Docker Compose stack is required. Make sure
135+
Docker is installed on your machine and run the following command.
125136

126137
```bash
127-
docker-compose up -d
128-
npm run test:e2e
138+
docker compose up -d
139+
pnpm test:e2e
129140
```
130141

131142
## Support

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
"dev": "tsc -p tsconfig.build.json --watch",
1414
"build": "tsc -p tsconfig.build.json && pnpm copy:proto",
1515
"copy:proto": "copyfiles lib/health-indicator/microservice/protos/health.proto dist/health-indicator/microservice/protos/health.proto",
16-
"build:all": "npm run build && pnpm run -r build",
17-
"test:all": "npm run test && pnpm run -if-present -r test --passWithNoTests",
16+
"build:all": "pnpm run build && pnpm run -r build",
17+
"test:all": "pnpm run test && pnpm run -if-present -r test --passWithNoTests",
1818
"test:e2e:all": "npm run test:e2e && pnpm run --if-present -r e2e --passWithNoTests",
1919
"format": "prettier --check \"{lib,e2e,sample,tools}/**/*.ts\"",
2020
"format:fix": "prettier --write \"{lib,e2e,sample,tools}/**/*.ts\"",
@@ -26,10 +26,10 @@
2626
"publish:next": "npm publish --access public --tag next",
2727
"prepublish:npm": "npm run build",
2828
"publish:npm": "npm publish --access public",
29-
"test": "npm run test:ut && npm run test:import",
29+
"test": "pnpm run test:ut && pnpm run test:import",
3030
"test:e2e": "jest --config=e2e/jest-e2e.json --detectOpenHandles --forceExit",
3131
"test:ut": "jest --detectOpenHandles",
32-
"test:ut:cov": "npm run test:ut -- --coverage",
32+
"test:ut:cov": "pnpm run test:ut -- --coverage",
3333
"test:import": "ts-node tools/import-check.ts",
3434
"release": "release-it",
3535
"prepare": "husky install"

0 commit comments

Comments
 (0)