refactor sse limit rate config

Signed-off-by: neo <[email protected]>

Author: neowu

core-ng/src/main/java/core/framework/internal/web/HTTPHandlerContext.java

@@ -13,7 +13,7 @@ public class HTTPHandlerContext {
     public final RequestBeanReader requestBeanReader = new RequestBeanReader();
     public final ResponseBeanWriter responseBeanWriter = new ResponseBeanWriter();
     public final RateControl rateControl = new RateControl();
-    public boolean limitRate;
+    public boolean limitRate;   // TODO: simplify this design?
     @Nullable
     public IPv4AccessControl accessControl;
 }

core-ng/src/main/java/core/framework/internal/web/sse/ChannelSupport.java

@@ -1,33 +1,34 @@
 package core.framework.internal.web.sse;
 
 import core.framework.web.Request;
+import core.framework.web.rate.LimitRate;
 import core.framework.web.sse.Channel;
 import core.framework.web.sse.ChannelListener;
 
-import java.lang.annotation.Annotation;
 import java.lang.reflect.Method;
 
 class ChannelSupport<T> {
     final ChannelListener<T> listener;
     final ServerSentEventContextImpl<T> context;
     final ServerSentEventBuilder<T> builder;
-    final Method targetMethod;
+    final LimitRate limitRate;
 
     ChannelSupport(ChannelListener<T> listener, Class<T> eventClass, ServerSentEventContextImpl<T> context) {
         this.listener = listener;
         this.context = context;
         builder = new ServerSentEventBuilder<>(eventClass);
+        limitRate = limitRate(listener);
+    }
+
+    private LimitRate limitRate(ChannelListener<T> listener) {
         try {
-            this.targetMethod = listener.getClass().getMethod("onConnect", Request.class, Channel.class, String.class);
+            Method targetMethod = listener.getClass().getMethod("onConnect", Request.class, Channel.class, String.class);
+            LimitRate limitRate = targetMethod.getDeclaredAnnotation(LimitRate.class);
+            if (limitRate == null)
+                limitRate = listener.getClass().getDeclaredAnnotation(LimitRate.class);
+            return limitRate;
         } catch (NoSuchMethodException e) {
             throw new Error("failed to get listener.onConnect method", e);
         }
     }
-
-    <V extends Annotation> V annotation(Class<V> annotationClass) {
-        V annotation = targetMethod.getDeclaredAnnotation(annotationClass);
-        if (annotation == null)
-            annotation = listener.getClass().getDeclaredAnnotation(annotationClass);
-        return annotation;
-    }
 }

core-ng/src/main/java/core/framework/internal/web/sse/ServerSentEventHandler.java

@@ -11,7 +11,6 @@
 import core.framework.internal.web.session.ReadOnlySession;
 import core.framework.internal.web.session.SessionManager;
 import core.framework.util.Strings;
-import core.framework.web.rate.LimitRate;
 import core.framework.web.sse.ChannelListener;
 import io.undertow.server.HttpHandler;
 import io.undertow.server.HttpServerExchange;
@@ -137,9 +136,8 @@ void handle(HttpServerExchange exchange, StreamSinkChannel sink) {
     }
 
     void limitRate(RateControl rateControl, ChannelSupport<Object> support, String clientIP) {
-        LimitRate limitRate = support.annotation(LimitRate.class);
-        if (limitRate != null) {
-            String group = limitRate.value();
+        if (support.limitRate != null) {
+            String group = support.limitRate.value();
             rateControl.validateRate(group, clientIP);
         }
     }