Skip to content

Enhancements and performance improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcfranco opened this issue Sep 26, 2023 · 0 comments
Open

Enhancements and performance improvements #2

jcfranco opened this issue Sep 26, 2023 · 0 comments

Comments

@jcfranco
Copy link

TL;DR

Made improvements to performance, cross-platform compatibility, and customization options in a fork. Open to collaborate and contribute these enhancements back to this project.


First of all, thanks for this awesome project. Timezone groups is a really interesting and useful concept. I stumbled upon it after reading your awesome medium posts and it's clear how much effort and expertise you've put into it.

Secondly, I did some exploration after forking your repo and managed to make the following modifications:

Enhancements/Improvements

  • improved performance
  • runs in both Node and in the browser
  • accepts arguments to specify:
    • the start date for the time zone group processing
    • the date range for creating the DST-aware time zone groups
    • other date libs to create the time zone groups
    • enable debug mode/messaging
  • use Intl to provide IANA time zones
  • use native APIs as much as possible to avoid using 3rd-party libraries
  • simplify output to reduce size and also reference timezone labels by index to allow for dynamic localization
  • provide hooks to customize output (experimental and undocumented [your thoughts would be greatly appreciated in this area to ensure the API is simple and flexible])

Would you be open to discussing potential collaboration between our versions? I'd be more than happy to contribute back to your repo if you find any of these changes to be helpful and align with your vision and goals. Your insights would be invaluable.

In any case, I believe these changes could benefit the community, so I've published timezone-groups to make it available for use for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant