Remove force setting exit code in CI ctest script

Author: ned14

.ci.cmake

@@ -152,7 +152,7 @@ else()
     )
     get_filename_component(toupload llfio-v2.0-binaries-linux-armhf.tgz ABSOLUTE)
   endif()
-  if(EXISTS "prebuilt/lib/libllfio_dl-2.0-Darwin-x86_64-Release.dylib")
+  if(EXISTS "prebuilt/lib/libllfio_dl-2.0-Darwin-arm64-Release.dylib")
     file(DOWNLOAD "https://github.com/ned14/outcome/tarball/master" "${CMAKE_CURRENT_LIST_DIR}/outcome.tgz")
     file(DOWNLOAD "https://github.com/ned14/quickcpplib/tarball/master" "${CMAKE_CURRENT_LIST_DIR}/quickcpplib.tgz")
     checked_execute_process("Tarring up binaries 0"
@@ -168,17 +168,17 @@ else()
       COMMAND "${CMAKE_COMMAND}" -E copy index.html llfio/
       COMMAND "${CMAKE_COMMAND}" -E copy Licence.txt llfio/
       COMMAND "${CMAKE_COMMAND}" -E copy Readme.md llfio/
-      COMMAND "${CMAKE_COMMAND}" -E copy prebuilt/lib/libllfio_sl-2.0-Darwin-x86_64-Release.a llfio/prebuilt/lib/
-      COMMAND "${CMAKE_COMMAND}" -E copy prebuilt/lib/libllfio_dl-2.0-Darwin-x86_64-Release.dylib llfio/prebuilt/lib/
+      COMMAND "${CMAKE_COMMAND}" -E copy prebuilt/lib/libllfio_sl-2.0-Darwin-arm64-Release.a llfio/prebuilt/lib/
+      COMMAND "${CMAKE_COMMAND}" -E copy prebuilt/lib/libllfio_dl-2.0-Darwin-arm64-Release.dylib llfio/prebuilt/lib/
     )
     checked_execute_process("Tarring up binaries 2"
       COMMAND bash -c "mv ned14-outcome* llfio/include/outcome"
       COMMAND bash -c "mv ned14-quickcpplib* llfio/include/quickcpplib"
     )
     checked_execute_process("Tarring up binaries 3"
-      COMMAND "${CMAKE_COMMAND}" -E tar cfz llfio-v2.0-binaries-darwin-x64.tgz llfio
+      COMMAND "${CMAKE_COMMAND}" -E tar cfz llfio-v2.0-binaries-darwin-arm64.tgz llfio
     )
-    get_filename_component(toupload llfio-v2.0-binaries-darwin-x64.tgz ABSOLUTE)
+    get_filename_component(toupload llfio-v2.0-binaries-darwin-arm64.tgz ABSOLUTE)
   endif()
 endif()
 set(retval2 0)
@@ -205,6 +205,5 @@ ctest_submit()
 if(NOT retval EQUAL 0 OR NOT retval2 EQUAL 0 OR NOT retval3 EQUAL 0)
   message(FATAL_ERROR "FATAL: Running tests exited with ${retval} ${retval2} ${retval3}")
 else()
-  message(STATUS "Running tests exited with ${retval} ${retval2} ${retval3}")
-  cmake_language(EXIT 0)
+  message(STATUS "SUCCESS: Running tests exited with ${retval} ${retval2} ${retval3}")
 endif()

.github/workflows/make_release.yml

@@ -131,8 +131,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ steps.create_release.outputs.upload_url }}
-          asset_path: artifacts/Mac OS error_code prebuilt binaries/llfio-v2.0-binaries-darwin-x64.tgz
-          asset_name: llfio-v2.0-binaries-macos-11-x64-error_code.tgz
+          asset_path: artifacts/Mac OS error_code prebuilt binaries/llfio-v2.0-binaries-darwin-arm64.tgz
+          asset_name: llfio-v2.0-binaries-macos-arm64-error_code.tgz
           asset_content_type: application/gzip
 
       - name: Upload MacOS 2
@@ -142,8 +142,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ steps.create_release.outputs.upload_url }}
-          asset_path: artifacts/Mac OS status_code prebuilt binaries/llfio-v2.0-binaries-darwin-x64.tgz
-          asset_name: llfio-v2.0-binaries-macos-11-x64-status_code.tgz
+          asset_path: artifacts/Mac OS status_code prebuilt binaries/llfio-v2.0-binaries-darwin-arm64.tgz
+          asset_name: llfio-v2.0-binaries-macos-arm64-status_code.tgz
           asset_content_type: application/gzip
 
       - name: Upload Windows 1

include/llfio/revision.hpp

@@ -1,4 +1,4 @@
 // Note the second line of this file must ALWAYS be the git SHA, third line ALWAYS the git SHA update time
-#define LLFIO_PREVIOUS_COMMIT_REF    f51d47933cf4cdf7ac0766818f1bed6ff39b779e
-#define LLFIO_PREVIOUS_COMMIT_DATE   "2024-08-22 09:34:43 +00:00"
-#define LLFIO_PREVIOUS_COMMIT_UNIQUE f51d4793
+#define LLFIO_PREVIOUS_COMMIT_REF    b2eef9e053c35ca7b8d7678169e578893b03fb9e
+#define LLFIO_PREVIOUS_COMMIT_DATE   "2024-08-22 12:11:35 +00:00"
+#define LLFIO_PREVIOUS_COMMIT_UNIQUE b2eef9e0

test/tests/process_handle.cpp

@@ -41,14 +41,16 @@ static inline void TestProcessHandle(bool with_redirection)
   {
     for(auto &i : *myenv)
     {
-      if(visit(i, [](auto sv) -> bool {
-           if(sv.size() >= 512)
-             return false;
-           using _string_view = std::decay_t<decltype(sv)>;
-           _string_view a((const typename _string_view::value_type *) "JENKINS_NEDPROD_PASSWORD");
-           _string_view b((const typename _string_view::value_type *) L"JENKINS_NEDPROD_PASSWORD");
-           return (sv.npos == sv.find(a)) && (sv.npos == sv.find(b));
-         }))
+      if(visit(i,
+               [](auto sv) -> bool
+               {
+                 if(sv.size() >= 512)
+                   return false;
+                 using _string_view = std::decay_t<decltype(sv)>;
+                 _string_view a((const typename _string_view::value_type *) "JENKINS_NEDPROD_PASSWORD");
+                 _string_view b((const typename _string_view::value_type *) L"JENKINS_NEDPROD_PASSWORD");
+                 return (sv.npos == sv.find(a)) && (sv.npos == sv.find(b));
+               }))
       {
         std::cout << "\n  " << i;
       }
@@ -63,7 +65,7 @@ static inline void TestProcessHandle(bool with_redirection)
   for(size_t n = 0; n < 4; n++)
   {
     char buffer[64];
-    sprintf(buffer, "--testchild,%u", (unsigned) n);
+    snprintf(buffer, 64, "--testchild,%u", (unsigned) n);
     llfio::path_view_component arg(buffer);
     children.push_back(llfio::process_handle::launch_process(myexepath, {&arg, 1}, flags).value());
   }