Skip to content

Commit c35f849

Browse files
committed
[change] remove 'resizeMode' static from 'Image'
Use strings instead of the 'Image.resizeMode' static. Corresponding change in React Native: facebook/react-native@870775e
1 parent 750790c commit c35f849

File tree

4 files changed

+4
-20
lines changed

4 files changed

+4
-20
lines changed

packages/react-native-web/src/exports/Image/__tests__/__snapshots__/index-test.js.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ exports[`components/Image prop "resizeMode" value "cover" 1`] = `"cover"`;
1212

1313
exports[`components/Image prop "resizeMode" value "none" 1`] = `"auto"`;
1414

15+
exports[`components/Image prop "resizeMode" value "repeat" 1`] = `"auto"`;
16+
1517
exports[`components/Image prop "resizeMode" value "stretch" 1`] = `"100% 100%"`;
1618

1719
exports[`components/Image prop "resizeMode" value "undefined" 1`] = `"cover"`;

packages/react-native-web/src/exports/Image/__tests__/index-test.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,7 @@ describe('components/Image', () => {
141141
});
142142

143143
describe('prop "resizeMode"', () => {
144-
[
145-
Image.resizeMode.contain,
146-
Image.resizeMode.cover,
147-
Image.resizeMode.none,
148-
Image.resizeMode.stretch,
149-
undefined
150-
].forEach(resizeMode => {
144+
['contain', 'cover', 'none', 'repeat', 'stretch', undefined].forEach(resizeMode => {
151145
test(`value "${resizeMode}"`, () => {
152146
const component = shallow(<Image resizeMode={resizeMode} />);
153147
expect(findImageSurfaceStyle(component).backgroundSize).toMatchSnapshot();
@@ -214,7 +208,7 @@ describe('components/Image', () => {
214208

215209
describe('prop "style"', () => {
216210
test('supports "resizeMode" property', () => {
217-
const component = shallow(<Image style={{ resizeMode: Image.resizeMode.contain }} />);
211+
const component = shallow(<Image style={{ resizeMode: 'contain' }} />);
218212
expect(findImageSurfaceStyle(component).backgroundSize).toMatchSnapshot();
219213
});
220214

packages/react-native-web/src/exports/Image/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,6 @@ class Image extends Component<*, State> {
132132
return ImageLoader.prefetch(uri);
133133
}
134134

135-
static resizeMode = ImageResizeMode;
136-
137135
_filterId = 0;
138136
_imageRef = null;
139137
_imageRequestId = null;

packages/website/storybook/1-components/Image/ImageScreen.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -136,16 +136,6 @@ const ImageScreen = () => (
136136
/>
137137
</Section>
138138

139-
<Section title="Properties">
140-
<DocItem
141-
name="static resizeMode"
142-
typeInfo="object"
143-
example={{
144-
code: '<Image resizeMode={Image.resizeMode.contain} />'
145-
}}
146-
/>
147-
</Section>
148-
149139
<Section title="Methods">
150140
<DocItem
151141
name="static getSize"

0 commit comments

Comments
 (0)