Skip to content

Commit e63952b

Browse files
StianSDouzetteStian S. Douzette
and
Stian S. Douzette
authored
Nytt oppsett for kall mot nytt medl endepunkt (#726)
* nytt medl-endepunkt, ident fra header og parametere flyttet inn i request body * endrer junit tester til å mocke kall med riktig oppsett mot riktig medl endepunkt * fikser på request body * Setter contentType til json i medl kall * fikser request body til riktig format * fikser riktig request body i mocking i tester * Fjerner ubrukt dato parameter i medl * Fjerner ubrukte imports --------- Co-authored-by: Stian S. Douzette <[email protected]>
1 parent 80e25c9 commit e63952b

File tree

3 files changed

+20
-17
lines changed

3 files changed

+20
-17
lines changed

src/main/kotlin/no/nav/medlemskap/clients/medl/MedlClient.kt

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,21 @@ class MedlClient(
2424

2525
private val logger = KotlinLogging.logger { }
2626

27-
suspend fun hentMedlemskapsunntak(ident: String, callId: String, fraOgMed: LocalDate? = null, tilOgMed: LocalDate? = null): List<MedlMedlemskapsunntak> {
27+
suspend fun hentMedlemskapsunntak(
28+
ident: String,
29+
callId: String
30+
): List<MedlMedlemskapsunntak> {
2831
val token = azureAdClient.hentToken(configuration.register.medlScope)
2932
return runCatching {
33+
val medlQuery = "{\"personident\": \"${ident}\"}"
3034
runWithRetryAndMetrics<List<MedlMedlemskapsunntak>>("Medl", "MedlemskapsunntakV1", retry) {
31-
httpClient.get() {
32-
url("$baseUrl/api/v1/medlemskapsunntak")
35+
httpClient.post() {
36+
url("$baseUrl/rest/v1/periode/soek")
3337
header(HttpHeaders.Authorization, "Bearer ${token.token}")
3438
header(HttpHeaders.Accept, ContentType.Application.Json)
39+
header(HttpHeaders.ContentType, ContentType.Application.Json)
3540
header("Nav-Call-Id", callId)
36-
header("Nav-Personident", ident)
37-
fraOgMed?.let { parameter("fraOgMed", fraOgMed.tilIsoFormat()) }
38-
tilOgMed?.let { parameter("tilOgMed", tilOgMed.tilIsoFormat()) }
41+
setBody(medlQuery)
3942
}.body()
4043
}
4144
}.fold(
@@ -52,6 +55,7 @@ class MedlClient(
5255
throw error
5356
}
5457
}
58+
5559
else -> throw error
5660
}
5761
}
@@ -68,4 +72,4 @@ class MedlClient(
6872
header(HttpHeaders.Accept, ContentType.Application.Json)
6973
}
7074
}
71-
}
75+
}

src/main/kotlin/no/nav/medlemskap/services/medl/MedlService.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ import java.time.LocalDate
55

66
class MedlService(private val medlClient: MedlClient) {
77

8-
suspend fun hentMedlemskapsunntak(ident: String, callId: String, fraOgMed: LocalDate? = null, tilOgMed: LocalDate? = null) =
9-
mapMedlemskapResultat(medlClient.hentMedlemskapsunntak(ident, callId, fraOgMed, tilOgMed))
8+
suspend fun hentMedlemskapsunntak(ident: String, callId: String) =
9+
mapMedlemskapResultat(medlClient.hentMedlemskapsunntak(ident, callId))
1010
}

src/test/kotlin/no/nav/medlemskap/clients/medl/medlClientTest.kt

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class medlClientTest {
6060
)
6161

6262
val client = createMedlClient(azureAdClient)
63-
val response = runBlocking { client.hentMedlemskapsunntak("10109000398", callId, LocalDate.of(2010, 1, 1), LocalDate.of(2016, 1, 1)) }
63+
val response = runBlocking { client.hentMedlemskapsunntak("10109000398", callId) }
6464

6565
Assertions.assertEquals("Full", response[0].dekning)
6666
Assertions.assertEquals(100064642, response[0].unntakId)
@@ -108,7 +108,7 @@ class medlClientTest {
108108
val client = createMedlClient(azureAdClient)
109109

110110
Assertions.assertThrows(ServerResponseException::class.java) {
111-
runBlocking { client.hentMedlemskapsunntak("10109000398", callId, LocalDate.of(2010, 1, 1), LocalDate.of(2016, 1, 1)) }
111+
runBlocking { client.hentMedlemskapsunntak("10109000398", callId) }
112112
}
113113
}
114114

@@ -131,7 +131,7 @@ class medlClientTest {
131131
val client = createMedlClient(azureAdClient)
132132

133133
Assertions.assertThrows(ClientRequestException::class.java) {
134-
runBlocking { client.hentMedlemskapsunntak("10109000398", callId, LocalDate.of(2010, 1, 1), LocalDate.of(2016, 1, 1)) }
134+
runBlocking { client.hentMedlemskapsunntak("10109000398", callId) }
135135
}
136136
}
137137

@@ -151,7 +151,7 @@ class medlClientTest {
151151
)
152152

153153
val client = createMedlClient(azureAdClient)
154-
val response = runBlocking { client.hentMedlemskapsunntak("10109000398", callId, LocalDate.of(2010, 1, 1), LocalDate.of(2016, 1, 1)) }
154+
val response = runBlocking { client.hentMedlemskapsunntak("10109000398", callId) }
155155

156156
Assertions.assertEquals(0, response.size)
157157
}
@@ -160,12 +160,11 @@ class medlClientTest {
160160
return MedlClient(server.baseUrl(), azureAdClient, config, cioHttpClient)
161161
}
162162

163-
private val queryMapping: MappingBuilder = WireMock.get(WireMock.urlPathEqualTo("/api/v1/medlemskapsunntak"))
163+
private val medlQuery = "{\"personident\": \"10109000398\"}"
164+
private val queryMapping: MappingBuilder = WireMock.post(WireMock.urlPathEqualTo("/rest/v1/periode/soek"))
164165
.withHeader(HttpHeaders.Authorization, equalTo("Bearer dummytoken"))
165-
.withHeader("Nav-Personident", equalTo("10109000398"))
166166
.withHeader("Nav-Call-Id", equalTo("12345"))
167-
.withQueryParam("fraOgMed", equalTo("2010-01-01"))
168-
.withQueryParam("fraOgMed", equalTo("2010-01-01"))
167+
.withRequestBody(equalTo(medlQuery))
169168

170169
private val medlResponse =
171170
"""

0 commit comments

Comments
 (0)