Skip to content

Commit a2fcec9

Browse files
committed
fix: update resource queries to use max by (container, namespace) for accurate limits and requests
1 parent 4027969 commit a2fcec9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

internal/utilization/queries.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ import (
1414
)
1515

1616
const (
17-
appCPULimit = `kube_pod_container_resource_limits{namespace=%q, container=%q, resource="cpu", unit="core"}`
18-
appCPURequest = `kube_pod_container_resource_requests{namespace=%q, container=%q, resource="cpu",unit="core"}`
17+
appCPULimit = `max by (container, namespace) (kube_pod_container_resource_limits{namespace=%q, container=%q, resource="cpu", unit="core"})`
18+
appCPURequest = `max by (container, namespace) (kube_pod_container_resource_requests{namespace=%q, container=%q, resource="cpu",unit="core"})`
1919
appCPUUsage = `rate(container_cpu_usage_seconds_total{namespace=%q, container=%q}[5m])`
20-
appMemoryLimit = `kube_pod_container_resource_limits{namespace=%q, container=%q, resource="memory", unit="byte"}`
21-
appMemoryRequest = `kube_pod_container_resource_requests{namespace=%q, container=%q, resource="memory",unit="byte"}`
20+
appMemoryLimit = `max by (container, namespace) (kube_pod_container_resource_limits{namespace=%q, container=%q, resource="memory", unit="byte"})`
21+
appMemoryRequest = `max by (container, namespace) (kube_pod_container_resource_requests{namespace=%q, container=%q, resource="memory",unit="byte"})`
2222
appMemoryUsage = `last_over_time(container_memory_working_set_bytes{namespace=%q, container=%q}[5m])`
2323
instanceCPUUsage = `rate(container_cpu_usage_seconds_total{namespace=%q, container=%q, pod=%q}[5m])`
2424
instanceMemoryUsage = `last_over_time(container_memory_working_set_bytes{namespace=%q, container=%q, pod=%q}[5m])`

0 commit comments

Comments
 (0)