Skip to content

Commit b51d87d

Browse files
authored
config client cache data race (#645)
* refine
1 parent d4949e1 commit b51d87d

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

clients/config_client/config_client.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -438,15 +438,16 @@ func (client *ConfigClient) executeConfigListen() {
438438
}
439439
}
440440

441-
for _, v := range caches {
442-
changeKey := util.GetConfigCacheKey(v.dataId, v.group, v.tenant)
441+
for _, v := range client.cacheMap.Items() {
442+
data := v.(cacheData)
443+
changeKey := util.GetConfigCacheKey(data.dataId, data.group, data.tenant)
443444
if _, ok := changeKeys[changeKey]; !ok {
444-
v.isSyncWithServer = true
445-
client.cacheMap.Set(changeKey, v)
445+
data.isSyncWithServer = true
446+
client.cacheMap.Set(changeKey, data)
446447
continue
447448
}
448-
v.isInitializing = true
449-
client.cacheMap.Set(changeKey, v)
449+
data.isInitializing = true
450+
client.cacheMap.Set(changeKey, data)
450451
}
451452

452453
}

0 commit comments

Comments
 (0)