Skip to content

Commit aabe3c2

Browse files
committed
fix(vrrp): display vrrp version by default
Make the VRRP version information always visible in the running configuration output, regardless of whether it's the default value (version 3) or not. When using frr-reload.py to apply configuration changes, VRRP instances were being unnecessarily reinitialized even when no actual configuration changes were made. This occurred because: The cli_show_vrrp function in vrrpd/vrrp_vty.c does not display the VRRP version in the show running-config output when it's the default value (version 3). Configuration files often explicitly specify vrrp X version 3 even though it's the default. When frr-reload.py compares the explicit configuration with the running configuration, it detects a difference and generates commands to remove and recreate the VRRP instance. This patch modifies the cli_show_vrrp function to unconditionally display the VRRP version, regardless of whether it's the default value or the show_defaults parameter is set. By making the version information explicit in all cases, we ensure consistent configuration comparison in frr-reload.py, preventing unnecessary VRRP reinitialization and associated network disruptions. Signed-off-by: echken <[email protected]>
1 parent c288e5f commit aabe3c2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

vrrpd/vrrp_vty.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ void cli_show_vrrp(struct vty *vty, const struct lyd_node *dnode, bool show_defa
6666
const char *ver = yang_dnode_get_string(dnode, "version");
6767

6868
vty_out(vty, " vrrp %s", vrid);
69-
if (show_defaults || !yang_dnode_is_default(dnode, "version"))
70-
vty_out(vty, " version %s", ver);
69+
vty_out(vty, " version %s", ver);
7170
vty_out(vty, "\n");
7271
}
7372

0 commit comments

Comments
 (0)