Skip to content

Commit 4ac02dd

Browse files
tomigandreini
andauthored
fix(editor): UX improvements to mfa setup modal (#9059)
Co-authored-by: Giulio Andreini <[email protected]>
1 parent 9f87cc2 commit 4ac02dd

File tree

3 files changed

+22
-9
lines changed

3 files changed

+22
-9
lines changed

packages/design-system/src/css/_tokens.dark.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,11 @@
194194
// Node error
195195
--color-node-error-output-text-color: var(--prim-color-alt-c-tint-150);
196196

197+
// MFA Recovery codes
198+
--color-mfa-recovery-code-background: var(--color-background-xlight);
199+
--color-mfa-recovery-code-color: var(--color-text-dark);
200+
--color-mfa-lose-access-text-color: var(--prim-color-alt-c-tint-150);
201+
197202
// Various
198203
--color-info-tint-1: var(--prim-gray-420);
199204
--color-info-tint-2: var(--prim-gray-740);

packages/design-system/src/css/_tokens.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,11 @@
270270
// Node error
271271
--color-node-error-output-text-color: var(--color-danger);
272272

273+
// MFA Recovery codes
274+
--color-mfa-recovery-code-background: var(--color-background-base);
275+
--color-mfa-recovery-code-color: var(--prim-gray-490);
276+
--color-mfa-lose-access-text-color: var(--color-danger);
277+
273278
// Various
274279
--color-avatar-accent-1: var(--prim-gray-120);
275280
--color-avatar-accent-2: var(--prim-color-alt-e-shade-100);

packages/editor-ui/src/components/MfaSetupModal.vue

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
<template>
22
<Modal
33
width="460px"
4+
height="80%"
5+
max-height="640px"
46
:title="
57
!showRecoveryCodes
68
? $locale.baseText('mfa.setup.step1.title')
@@ -274,6 +276,12 @@ export default defineComponent({
274276
</script>
275277

276278
<style module lang="scss">
279+
.container {
280+
display: flex;
281+
flex-direction: column;
282+
height: 100%;
283+
}
284+
277285
.container > * {
278286
overflow: visible;
279287
margin-bottom: var(--spacing-s);
@@ -303,10 +311,9 @@ export default defineComponent({
303311
text-align: center;
304312
}
305313
.recoveryCodesContainer {
306-
height: 140px;
307314
display: flex;
308315
flex-direction: column;
309-
background-color: var(--color-background-base);
316+
background-color: var(--color-mfa-recovery-code-background);
310317
text-align: center;
311318
flex-wrap: nowrap;
312319
justify-content: space-between;
@@ -316,14 +323,14 @@ export default defineComponent({
316323
padding-bottom: var(--spacing-xs);
317324
gap: var(--spacing-xs);
318325
margin-bottom: var(--spacing-2xs);
319-
overflow-y: scroll;
326+
overflow-y: auto;
320327
}
321328
322329
.recoveryCodesContainer span {
323330
font-size: var(--font-size-s);
324331
font-weight: var(--font-weight-regular);
325332
line-height: var(--spacing-m);
326-
color: #7d7d87;
333+
color: var(--color-mfa-recovery-code-color);
327334
}
328335
329336
.form:first-child span {
@@ -341,7 +348,7 @@ export default defineComponent({
341348
}
342349
343350
.loseAccessText {
344-
color: var(--color-danger);
351+
color: var(--color-mfa-lose-access-text-color);
345352
}
346353
347354
.error input {
@@ -362,8 +369,4 @@ export default defineComponent({
362369
.notice {
363370
margin: 0;
364371
}
365-
366-
.modalContent {
367-
overflow: hidden;
368-
}
369372
</style>

0 commit comments

Comments
 (0)