Skip to content

Review metrics usage #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Frando opened this issue Apr 16, 2025 · 0 comments
Open

Review metrics usage #3270

Frando opened this issue Apr 16, 2025 · 0 comments

Comments

@Frando
Copy link
Member

Frando commented Apr 16, 2025

Check that all metrics have a proper description, and are used accordingly.

  • magicsock.num_relay_conns_added is incremented for two different meanings on main: When a peer switches to a relay path, and when we open a new connection to a relay. Those are completely different things, and we should ofc use different metrics.
@Frando Frando mentioned this issue Apr 16, 2025
Merged
9 tasks
@n0bot n0bot bot added this to iroh Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
iroh
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Frando