-
Notifications
You must be signed in to change notification settings - Fork 235
chore(iroh): Add echo-no-router.rs
example
#3267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would go for a sub-directory called "router" and move the router examples into there. But that might be more controversial.
Anyway, all comments rather cosmetic and I don't mind if you do something about them or not. Apart from the connect-side not closing the endpoint. That's rather critical.
Please re-review :) |
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3267/docs/iroh/ Last updated: 2025-04-17T09:04:28Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch on also fixing the original example!
Co-authored-by: Floris Bruynooghe <[email protected]>
Description
Adds an example showing how to implement a basic protocol without using a
Router
.As a bonus, one can compare what
echo.rs
andecho-no-router.rs
are doing to see the difference.Notes & open questions
I think this is slightly useful, but YMMV. I don't think it's a lot of work to maintain though.
Change checklist