Skip to content

chore(iroh): Add echo-no-router.rs example #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Conversation

matheus23
Copy link
Member

Description

Adds an example showing how to implement a basic protocol without using a Router.
As a bonus, one can compare what echo.rs and echo-no-router.rs are doing to see the difference.

Notes & open questions

I think this is slightly useful, but YMMV. I don't think it's a lot of work to maintain though.

Change checklist

  • Self-review.

@matheus23 matheus23 self-assigned this Apr 16, 2025
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would go for a sub-directory called "router" and move the router examples into there. But that might be more controversial.

Anyway, all comments rather cosmetic and I don't mind if you do something about them or not. Apart from the connect-side not closing the endpoint. That's rather critical.

@n0bot n0bot bot added this to iroh Apr 16, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Apr 16, 2025
@matheus23
Copy link
Member Author

Anyway, all comments rather cosmetic and I don't mind if you do something about them or not. Apart from the connect-side not closing the endpoint. That's rather critical.

Please re-review :)

Copy link

github-actions bot commented Apr 16, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3267/docs/iroh/

Last updated: 2025-04-17T09:04:28Z

Copy link

github-actions bot commented Apr 16, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 9c8589d

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch on also fixing the original example!

@matheus23 matheus23 enabled auto-merge April 17, 2025 09:02
@matheus23 matheus23 added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 7e13aa3 Apr 17, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Apr 17, 2025
@matheus23 matheus23 deleted the matheus23/echo-no-router branch April 17, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants