fix(iroh): Reap ActiveRelayActor handles for idle relays #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ActiveRelayActor exists when it is idle for a while (60s for now). When it does the RelayActor is supposed to notice the tasks exists and clean up the handles it keeps to all the ActiveRelayActors. Unfortunately it was only doing this for ActiveRelayActors which errored and not for those that exited normally because they were idle. This makes sure to also reap active relay handles when the actor exists normally. Additionally this stops propagating the panic. The relay actor itself is currently spawned without keeping track of the handle. Panicking it would make it disappear silently. Propagating panics is reasonable, but I don't want to fix the task spawning. That's for another time.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3249/docs/iroh/ Last updated: 2025-03-27T12:50:41Z |
flub
commented
Mar 27, 2025
| Err(err) if err.is_cancelled() => { | ||
| error!("ActiveRelayActor cancelled: {err:#?}"); | ||
| } | ||
| Err(err) => error!("ActiveRelayActor failed: {err:#?}"), |
There was a problem hiding this comment.
Look, aren't real rust matching semantics nice? The compiler told me I had a case that wasn't covered (ok, ok. The compiler is actually wrong because task errors are always either panics or cancelled, tokio doesn't allow anything else. But still, the compiler is right.)
ramfox
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ActiveRelayActor exists when it is idle for a while (60s for now).
When it does the RelayActor is supposed to notice the tasks exists and
clean up the handles it keeps to all the ActiveRelayActors.
Unfortunately it was only doing this for ActiveRelayActors which
errored and not for those that exited normally because they were idle.
This makes sure to also reap active relay handles when the actor
exists normally.
Additionally this stops propagating the panic. The relay actor itself
is currently spawned without keeping track of the handle. Panicking
it would make it disappear silently. Propagating panics is
reasonable, but I don't want to fix the task spawning. That's for
another time.
Breaking Changes
Notes & open questions
I looked at writing a test for this, but testing the RelayActor is
still something that's difficult to do. So sadly no tests.
Change checklist