feat!: add DiscoveryItem::user_data method and adjust locally-discovered-nodes example
#3215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3215/docs/iroh/ Last updated: 2025-03-14T00:46:03Z |
ramfox
force-pushed
the
ramfox/local-discovery-example
branch
from
cb2091c to
3fa7fee
Compare
|
Looks good! Needs a Breaking changes note for the rename to Mdns. |
Frando
approved these changes
Mar 10, 2025
Frando
approved these changes
Mar 12, 2025
ramfox
changed the title
DiscoveryItem::user_data method and adjust locally-discovered-nodes exampleDiscoveryItem::user_data method and adjust locally-discovered-nodes example
added 3 commits
March 13, 2025 20:44
ramfox
force-pushed
the
ramfox/local-discovery-example
branch
from
bf233d8 to
11280b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the
locally-discovered-nodesexample to use the newuser_dataanddiscovery_streammethods.Renamed
LocalSwarmDiscoverytoMdnsDiscoveryBreaking Changes
iroh::discovery::local_swarm_discoverytoiroh::discovery::mdnsiroh::discovery::local_swarm_discovery::LocalSwarmDiscoverytoiroh::discovery::mdns::MdnsDiscoveryChange checklist