refactor!: remove iroh-test crate #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can just use AbortOnDropHandle where needed
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3162/docs/iroh/ Last updated: 2025-02-03T15:31:39Z |
flub
approved these changes
Feb 3, 2025
iroh/src/magicsock.rs
Outdated
| @@ -3238,22 +3238,19 @@ mod tests { | |||
|
|
|||
| // For each node, start a task which monitors its local endpoints and registers them | |||
| // with the other nodes as local endpoints become known. | |||
| let mut tasks = JoinSet::new(); | |||
| let mut tasks = Vec::new(); | |||
There was a problem hiding this comment.
Wait? What? A JoinSet aborts all tasks on drop already. Why are we jumping through all these hoops?
There was a problem hiding this comment.
bonus fun 🤣 I can go back to joinset I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These testutils we are using, actually can be replaced through either simpler code or other crates. See the individual commits for the alternatives
Breaking Changes
iroh-testcrate is goneNotes & open questions
Change checklist