fix(iroh): Implement Clone for StaticProvider discovery #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3108/docs/iroh/ Last updated: 2025-01-09T08:56:57Z |
Nothing in the trait stops it from working for discovery structs which are Arc'ed. Not all discovery types are in control of the users so this is helpful. I stumbled upon this because StaticProvider is not Clone.
flub
force-pushed
the
flub/discovery-arc
branch
from
bf23bbe to
4d28dfa
Compare
This is not very useful without Clone, it already is Arc<RwLock<T>> on the inside to this clearly was intended. Write a test demonstrating why this is needed.
flub
force-pushed
the
flub/discovery-clone
branch
from
5af139d to
07de2c8
Compare
dignifiedquire
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is not very useful without Clone, it already is Arc<RwLock> on the inside so this clearly was intended. Write a test demonstrating why this is needed.
Breaking Changes
Notes & open questions
Change checklist