refactor(iroh)!: make iroh::tls private #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes `iroh::tls` private - match quinns tls setup for benchmarking
dignifiedquire
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3018/docs/iroh/ Last updated: 2024-12-10T11:25:40Z |
rklaehn
approved these changes
Dec 9, 2024
| @@ -189,7 +189,7 @@ jobs: | |||
| # uses: obi1kenobi/cargo-semver-checks-action@v2 | |||
| uses: n0-computer/cargo-semver-checks-action@feat-baseline | |||
| with: | |||
| package: iroh, iroh-base, iroh-dns-server, iroh-net-bench, iroh-relay, iroh-net-report | |||
| package: iroh, iroh-base, iroh-dns-server, iroh-bench, iroh-relay, iroh-net-report | |||
There was a problem hiding this comment.
so iroh-net-report does not get renamed to iroh-report for now?
There was a problem hiding this comment.
don't know if we want to do that, but that's seperate from this PR
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iroh::tlsprivateBreaking Changes
iroh::tlsis removed from the public APINotes & open questions
The goal is to reduce the API surface of
iroh, to what is really needed. I couldn't find any critical usage of this in our dependencies.Change checklist