feat!: reduce default feature dependents #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3005/docs/iroh/ Last updated: 2024-12-05T13:03:58Z |
matheus23
reviewed
Dec 4, 2024
dignifiedquire
force-pushed
the
fix-feature-flags
branch
from
d6d1e72 to
4d97824
Compare
dignifiedquire
changed the title
flub
approved these changes
Dec 5, 2024
| #![cfg_attr( | ||
| not(feature = "server"), | ||
| doc = "- `server`: A fully-fledged iroh-relay server over HTTP or HTTPS." | ||
| )] |
rklaehn
approved these changes
Dec 5, 2024
| @@ -11,8 +11,16 @@ | |||
| //! - [`protos::relay`]: The protocol used to communicate between relay servers and clients. It's a | |||
| //! revised version of the Designated Encrypted Relay for Packets (DERP) protocol written by | |||
| //! Tailscale. | |||
| //! - [`server`]: A fully-fledged iroh-relay server over HTTP or HTTPS. Optionally will also | |||
| //! expose a stun endpoint and metrics. | |||
| #
There was a problem hiding this comment.
🙄 are we doing this all the time now?
There was a problem hiding this comment.
because folks like links, and this is the only way to make them dependent on feature flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relay/serverdefault featuremetricsfeature as necessaryBreaking Changes
serveris not a default feature iniroh-relayanymoreNotes & open questions
Change checklist