feat(iroh-net): Export the Ticket trait #2765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exports the Ticket trait, which is kind of needed to work with the NodeTicket. Also updates the docs of tickets a little.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2765/docs/iroh/ Last updated: 2024-10-01T09:27:31Z |
|
Netsim report & logs for this PR have been generated and is available at: LOGS Last updated for commit: 8aa86f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This exports the Ticket trait, which is kind of needed to work with
the NodeTicket. Since NodeTicket is already provided directly in
iroh-net it is very strange to force users to pull in iroh-base to get
the ticket trait.
Also updates the docs of tickets a little.
Breaking Changes
None
Notes & open questions
None
Change checklist
[ ] Tests if relevant.[ ] All breaking changes documented.