fix(iroh-relay): fix client actors not closing (#3134)

## Description

When a client actor closes, it awaits `Clients::unregister`, which then
awaits for the actor task to close, so almost every actor task was being
leaked. Since the only place `Clients::unregister` is called is from
when the actor is already closing, I chose to break the cycle by not
have it call `Client::shutdown`.

I also added a timeout to the tls handshake because that also gets stuck
forever if the client goes away. I didn't add it to the `LetsEncrypt`
acceptor because I wasn't sure where exactly it belonged, but that
should probably have one too. I can move this to a separate PR if
preferred. Maybe the timeout should be configurable as well?

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.

---------

Co-authored-by: Floris Bruynooghe <[email protected]>

Author: PaulOlteanu

iroh-relay/src/server/client.rs

@@ -221,9 +221,7 @@ impl Actor {
             }
         }
 
-        self.clients
-            .unregister(self.connection_id, self.node_id)
-            .await;
+        self.clients.unregister(self.connection_id, self.node_id);
     }
 
     async fn run_inner(&mut self, done: CancellationToken) -> Result<()> {

iroh-relay/src/server/clients.rs

@@ -71,7 +71,7 @@ impl Clients {
     /// peer is gone from the network.
     ///
     /// Must be passed a matching connection_id.
-    pub(super) async fn unregister(&self, connection_id: u64, node_id: NodeId) {
+    pub(super) fn unregister(&self, connection_id: u64, node_id: NodeId) {
         trace!(
             node_id = node_id.fmt_short(),
             connection_id,
@@ -102,7 +102,6 @@ impl Clients {
                     }
                 }
             }
-            client.shutdown().await;
         }
     }
 

iroh-relay/src/server/http_server.rs

@@ -644,7 +644,11 @@ impl RelayService {
             },
             TlsAcceptor::Manual(a) => {
                 debug!("TLS[manual]: accept");
-                let tls_stream = a.accept(stream).await.context("TLS[manual] accept")?;
+                let tls_stream = tokio::time::timeout(Duration::from_secs(30), a.accept(stream))
+                    .await
+                    .context("TLS[manual] timeout")?
+                    .context("TLS[manual] accept")?;
+
                 self.serve_connection(MaybeTlsStream::Tls(tls_stream))
                     .await
                     .context("TLS[manual] serve connection")?;