Skip to content

Commit d37a4a4

Browse files
authored
tests(iroh-net): Remove a flaky test (#2379)
## Description This flakyness seems to have been successfully addressed by the staggered DNS lookup. Converting this test to that basically results in the same code as the next test: test_dns_lookup_ipv4_ipv6. So just remove this test as it no longer provides value. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions See #2380 for the flaky test. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates if relevant.~~ - [x] Tests if relevant. - ~~[ ] All breaking changes documented.~~
1 parent 4ff1ec4 commit d37a4a4

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

iroh-net/src/dns.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -387,17 +387,6 @@ pub(crate) mod tests {
387387
const TIMEOUT: Duration = Duration::from_secs(5);
388388
const STAGGERING_DELAYS: &[u64] = &[200, 300];
389389

390-
#[tokio::test]
391-
#[cfg_attr(target_os = "windows", ignore = "flaky")]
392-
async fn test_dns_lookup_basic() {
393-
let _logging = iroh_test::logging::setup();
394-
let resolver = default_resolver();
395-
let res = resolver.lookup_ip(NA_RELAY_HOSTNAME).await.unwrap();
396-
let res: Vec<_> = res.iter().collect();
397-
assert!(!res.is_empty());
398-
dbg!(res);
399-
}
400-
401390
#[tokio::test]
402391
async fn test_dns_lookup_ipv4_ipv6() {
403392
let _logging = iroh_test::logging::setup();

iroh/src/node.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,7 @@ mod tests {
415415
}
416416

417417
#[cfg(feature = "fs-store")]
418+
#[ignore = "flaky"]
418419
#[tokio::test]
419420
async fn test_default_author_persist() -> Result<()> {
420421
use crate::util::path::IrohPaths;

0 commit comments

Comments
 (0)