Skip to content

Commit cf3e650

Browse files
authored
fix(iroh): Reduce log-level of unknown pong message (#3242)
## Description Turns out we get this normally when they are just delayed due to saturated traffic. That's not something that's worth spamming WARN all over the placed for. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review.
1 parent 7588135 commit cf3e650

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

iroh/src/magicsock/node_map/node_state.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -898,8 +898,10 @@ impl NodeState {
898898
let is_relay = src.is_relay();
899899
match self.sent_pings.remove(&m.tx_id) {
900900
None => {
901-
// This is not a pong for a ping we sent.
902-
warn!(tx = %HEXLOWER.encode(&m.tx_id), "received pong with unknown transaction id");
901+
// This is not a pong for a ping we sent. In reality however we probably
902+
// did send this ping but it has timed-out by the time we receive this pong
903+
// so we removed the state already.
904+
debug!(tx = %HEXLOWER.encode(&m.tx_id), "received unknown pong (did it timeout?)");
903905
None
904906
}
905907
Some(sp) => {

0 commit comments

Comments
 (0)