Skip to content

Commit 8b6245e

Browse files
fix(ci): report flaky outupt only on success and failure (#2627)
## Description in #2623 the condition for `notify` is not being cancelled, but a job can also be skipped. This is the output when a PR is not even running the tests. So, we get a good report in cases where there was no output. This fixes that issue ## Breaking Changes n/a ## Notes & open questions n/a ## Change checklist - [x] Self-review. - [ ] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [ ] ~~Tests if relevant.~~ - [ ] ~~All breaking changes documented.~~
1 parent e9c5088 commit 8b6245e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/flaky.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
echo "$EOF" >> $GITHUB_OUTPUT
9292
- name: Notify discord on failure
9393
uses: n0-computer/discord-webhook-notify@v1
94-
if: ${{ env.TESTS_RESULT != 'cancelled' }}
94+
if: ${{ env.TESTS_RESULT == 'failure' || env.TESTS_RESULT == 'success' }}
9595
with:
9696
severity: ${{ env.TESTS_RESULT == 'failure' && 'warn' || 'info' }}
9797
details: ${{ env.TESTS_RESULT == 'failure' && steps.make_summary.outputs.summary || 'No flaky failures!' }}

0 commit comments

Comments
 (0)