Merge pull request #296 from esauvisky/fix-systemctl-spam

mzur · web-flow · commit a8aed7e8b464 · 2024-12-23T20:29:58.000+01:00
WorkspaceSwitcherPopup: fix spam on systemd journal
diff --git a/wsmatrix@martin.zurowietz.de/workspacePopup/workspaceSwitcherPopup.js b/wsmatrix@martin.zurowietz.de/workspacePopup/workspaceSwitcherPopup.js
@@ -190,14 +190,15 @@ class WorkspaceSwitcherPopup extends SwitcherPopup {
             this._noModsTimeoutId = 0;
         }
 
+        this._items.forEach((x) => x.destroy());
+        this._items = [];
+
         super._onDestroy();
 
         while (modals.length > 0) {
             modals.pop().destroy();
         }
 
-        this._items.forEach((x) => x.destroy());
-        this._items = [];
     }
 
     vfunc_allocate(box) {

Original file line number	Diff line number	Diff line change
`@@ -190,14 +190,15 @@ class WorkspaceSwitcherPopup extends SwitcherPopup {`
`190`	`190`	`this._noModsTimeoutId = 0;`
`191`	`191`	`}`
`192`	`192`
	`193`	`+ this._items.forEach((x) => x.destroy());`
	`194`	`+ this._items = [];`
	`195`	`+`
`193`	`196`	`super._onDestroy();`
`194`	`197`
`195`	`198`	`while (modals.length > 0) {`
`196`	`199`	`modals.pop().destroy();`
`197`	`200`	`}`
`198`	`201`
`199`		`- this._items.forEach((x) => x.destroy());`
`200`		`- this._items = [];`
`201`	`202`	`}`
`202`	`203`
`203`	`204`	`vfunc_allocate(box) {`