Skip to content

Commit fe98cb4

Browse files
committed
Remove storage todos (replaced with issues: googleapis#288 googleapis#289 googleapis#290 googleapis#291 googleapis#292)
1 parent 33e932e commit fe98cb4

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java

-3
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
293293
Map<Option, ?> targetOptions) throws StorageException {
294294
ComposeRequest request = new ComposeRequest();
295295
if (target.getContentType() == null) {
296-
// todo: remove once this is no longer requirement (b/20681287).
297296
target.setContentType("application/octet-stream");
298297
}
299298
request.setDestination(target);
@@ -311,7 +310,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
311310
}
312311
request.setSourceObjects(sourceObjects);
313312
try {
314-
// todo: missing setProjection (b/20659000)
315313
return storage.objects()
316314
.compose(target.getBucket(), target.getName(), request)
317315
.setIfMetagenerationMatch(IF_METAGENERATION_MATCH.getLong(targetOptions))
@@ -435,7 +433,6 @@ public byte[] read(StorageObject from, Map<Option, ?> options, long position, in
435433
.setIfGenerationMatch(IF_GENERATION_MATCH.getLong(options))
436434
.setIfGenerationNotMatch(IF_GENERATION_NOT_MATCH.getLong(options));
437435
MediaHttpDownloader downloader = req.getMediaHttpDownloader();
438-
// todo: Fix int casting (https://github.com/google/google-api-java-client/issues/937)
439436
downloader.setContentRange(position, (int) position + bytes);
440437
downloader.setDirectDownloadEnabled(true);
441438
ByteArrayOutputStream output = new ByteArrayOutputStream();

gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java

-2
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ public RetryResult beforeEval(Exception exception) {
102102
StorageImpl(StorageOptions options) {
103103
super(options);
104104
storageRpc = options.storageRpc();
105-
// todo: provide rewrite - https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite
106-
// todo: check if we need to expose https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert vs using bucket update/patch
107105
}
108106

109107
@Override

0 commit comments

Comments
 (0)