[ISSUE #1253]⚡️Optimize RouteInfoManager in NameServerBootstrap, remove RouteInfoManager parking_lot::RwLock

Author: mxsm

rocketmq-broker/src/out_api/broker_outer_api.rs

@@ -276,13 +276,9 @@ impl BrokerOuterAPI {
                         result.ha_server_addr = header
                             .ha_server_addr
                             .clone()
-                            .unwrap_or(CheetahString::empty())
-                            .to_string();
-                        result.master_addr = header
-                            .master_addr
-                            .clone()
-                            .unwrap_or(CheetahString::empty())
-                            .to_string();
+                            .unwrap_or(CheetahString::empty());
+                        result.master_addr =
+                            header.master_addr.clone().unwrap_or(CheetahString::empty());
                     }
                     if let Some(body) = response.body() {
                         result.kv_table = SerdeJsonUtils::decode::<KVTable>(body.as_ref()).unwrap();

rocketmq-namesrv/src/bootstrap.rs

@@ -52,7 +52,7 @@ struct NameServerRuntime {
     name_server_config: ArcMut<NamesrvConfig>,
     tokio_client_config: Arc<TokioClientConfig>,
     server_config: Arc<ServerConfig>,
-    route_info_manager: Arc<parking_lot::RwLock<RouteInfoManager>>,
+    route_info_manager: RouteInfoManager,
     kvconfig_manager: KVConfigManager,
     name_server_runtime: Option<RocketMQRuntime>,
     remoting_client: ArcMut<RocketmqDefaultClient>,
@@ -108,13 +108,13 @@ impl NameServerRuntime {
                 self.kvconfig_manager.clone(),
             );
 
-        let route_info_manager_arc = self.route_info_manager.clone();
+        let mut route_info_manager_arc = self.route_info_manager.clone();
         self.name_server_runtime
             .as_ref()
             .unwrap()
-            .schedule_at_fixed_rate(
+            .schedule_at_fixed_rate_mut(
                 move || {
-                    route_info_manager_arc.write().scan_not_active_broker();
+                    route_info_manager_arc.scan_not_active_broker();
                 },
                 Some(Duration::from_secs(5)),
                 Duration::from_secs(5),
@@ -172,10 +172,10 @@ impl Builder {
                 name_server_config: name_server_config.clone(),
                 tokio_client_config,
                 server_config: Arc::new(self.server_config.unwrap()),
-                route_info_manager: Arc::new(parking_lot::RwLock::new(RouteInfoManager::new(
+                route_info_manager: RouteInfoManager::new(
                     name_server_config.clone(),
                     remoting_client.clone(),
-                ))),
+                ),
                 kvconfig_manager: KVConfigManager::new(name_server_config),
                 name_server_runtime: Some(runtime),
                 remoting_client,

rocketmq-namesrv/src/processor/client_request_processor.rs

@@ -17,7 +17,6 @@
 
 use std::sync::atomic::AtomicBool;
 use std::sync::atomic::Ordering;
-use std::sync::Arc;
 use std::time::Duration;
 
 use cheetah_string::CheetahString;
@@ -40,7 +39,7 @@ use crate::processor::NAMESPACE_ORDER_TOPIC_CONFIG;
 use crate::route::route_info_manager::RouteInfoManager;
 
 pub struct ClientRequestProcessor {
-    route_info_manager: Arc<parking_lot::RwLock<RouteInfoManager>>,
+    route_info_manager: RouteInfoManager,
     namesrv_config: ArcMut<NamesrvConfig>,
     need_check_namesrv_ready: AtomicBool,
     startup_time_millis: u64,
@@ -49,7 +48,7 @@ pub struct ClientRequestProcessor {
 
 impl ClientRequestProcessor {
     pub fn new(
-        route_info_manager: Arc<parking_lot::RwLock<RouteInfoManager>>,
+        route_info_manager: RouteInfoManager,
         namesrv_config: ArcMut<NamesrvConfig>,
         kvconfig_manager: KVConfigManager,
     ) -> Self {
@@ -82,7 +81,6 @@ impl ClientRequestProcessor {
         }
         match self
             .route_info_manager
-            .read()
             .pickup_topic_route_data(request_header.topic.as_ref())
         {
             None => RemotingCommand::create_response_command_with_code(ResponseCode::TopicNotExist)