Skip to content

Commit e7934db

Browse files
committed
ping/rust: Don't set PR ref for master build
When building the `master` image we would previously mistakingly set the ref to the PR commit hash. This surfaced when testing a pull request from a fork. `master` would be pointed at the forks HEAD commit hash, but not the fork URL. Thus the build could not find the commit and would fail. See libp2p/rust-libp2p#3154
1 parent 17dcc6c commit e7934db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ping/_compositions/rust-cross-versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
[groups.build_config.build_args]
2727
BINARY_NAME = '{{ .BinaryName }}'
28-
GIT_REF = '{{ $.Env.GitReference }}'
28+
GIT_REF = "master"
2929
{{ end }}
3030

3131
{{ if $.Env.GitReference }}

0 commit comments

Comments
 (0)