Skip to content

Commit 5a5df88

Browse files
authored
Rename CaptureStringVal to CaptureString (#278)
1 parent 5426748 commit 5a5df88

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

meg_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func TestMatchAndCaptureMultiaddr(t *testing.T) {
1717
meg.Val(P_IP4),
1818
meg.Val(P_IP6),
1919
),
20-
meg.CaptureStringVal(P_UDP, &udpPort),
20+
meg.CaptureString(P_UDP, &udpPort),
2121
meg.Val(P_QUIC_V1),
2222
meg.Val(P_WEBTRANSPORT),
2323
meg.CaptureZeroOrMoreStrings(P_CERTHASH, &certhashes),

x/meg/bench_test.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -97,16 +97,16 @@ func isWebTransportMultiaddrPrealloc() *preallocatedCapture {
9797
var sni string
9898
p.matcher = meg.PatternToMatcher(
9999
meg.Or(
100-
meg.CaptureStringVal(multiaddr.P_IP4, &ip4Addr),
101-
meg.CaptureStringVal(multiaddr.P_IP6, &ip6Addr),
102-
meg.CaptureStringVal(multiaddr.P_DNS4, &dnsName),
103-
meg.CaptureStringVal(multiaddr.P_DNS6, &dnsName),
104-
meg.CaptureStringVal(multiaddr.P_DNS, &dnsName),
100+
meg.CaptureString(multiaddr.P_IP4, &ip4Addr),
101+
meg.CaptureString(multiaddr.P_IP6, &ip6Addr),
102+
meg.CaptureString(multiaddr.P_DNS4, &dnsName),
103+
meg.CaptureString(multiaddr.P_DNS6, &dnsName),
104+
meg.CaptureString(multiaddr.P_DNS, &dnsName),
105105
),
106-
meg.CaptureStringVal(multiaddr.P_UDP, &udpPort),
106+
meg.CaptureString(multiaddr.P_UDP, &udpPort),
107107
meg.Val(multiaddr.P_QUIC_V1),
108108
meg.Optional(
109-
meg.CaptureStringVal(multiaddr.P_SNI, &sni),
109+
meg.CaptureString(multiaddr.P_SNI, &sni),
110110
),
111111
meg.Val(multiaddr.P_WEBTRANSPORT),
112112
meg.CaptureZeroOrMoreStrings(multiaddr.P_CERTHASH, &p.certHashes),
@@ -130,16 +130,16 @@ func IsWebTransportMultiaddr(m multiaddr.Multiaddr) (bool, int) {
130130
var certHashesStr []string
131131
matched, _ := m.Match(
132132
meg.Or(
133-
meg.CaptureStringVal(multiaddr.P_IP4, &ip4Addr),
134-
meg.CaptureStringVal(multiaddr.P_IP6, &ip6Addr),
135-
meg.CaptureStringVal(multiaddr.P_DNS4, &dnsName),
136-
meg.CaptureStringVal(multiaddr.P_DNS6, &dnsName),
137-
meg.CaptureStringVal(multiaddr.P_DNS, &dnsName),
133+
meg.CaptureString(multiaddr.P_IP4, &ip4Addr),
134+
meg.CaptureString(multiaddr.P_IP6, &ip6Addr),
135+
meg.CaptureString(multiaddr.P_DNS4, &dnsName),
136+
meg.CaptureString(multiaddr.P_DNS6, &dnsName),
137+
meg.CaptureString(multiaddr.P_DNS, &dnsName),
138138
),
139-
meg.CaptureStringVal(multiaddr.P_UDP, &udpPort),
139+
meg.CaptureString(multiaddr.P_UDP, &udpPort),
140140
meg.Val(multiaddr.P_QUIC_V1),
141141
meg.Optional(
142-
meg.CaptureStringVal(multiaddr.P_SNI, &sni),
142+
meg.CaptureString(multiaddr.P_SNI, &sni),
143143
),
144144
meg.Val(multiaddr.P_WEBTRANSPORT),
145145
meg.CaptureZeroOrMoreStrings(multiaddr.P_CERTHASH, &certHashesStr),

x/meg/meg_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ func TestCapture(t *testing.T) {
199199
{
200200
setup: func() (Matcher, func()) {
201201
var code0str string
202-
return PatternToMatcher(CaptureStringVal(0, &code0str), Val(1)), func() {
202+
return PatternToMatcher(CaptureString(0, &code0str), Val(1)), func() {
203203
if code0str != "hello" {
204204
panic("unexpected value")
205205
}

x/meg/sugar.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,13 @@ func CaptureWithF(code int, f CaptureFunc) Pattern {
156156
}
157157

158158
func Val(code int) Pattern {
159-
return CaptureStringVal(code, nil)
159+
return CaptureString(code, nil)
160160
}
161161

162162
// Any is a special code that matches any value.
163163
var Any int = matchAny
164164

165-
func CaptureStringVal(code int, val *string) Pattern {
165+
func CaptureString(code int, val *string) Pattern {
166166
return CaptureWithF(code, captureOneStringValueOrErr(val))
167167
}
168168

0 commit comments

Comments
 (0)