Skip to content

[Form Styling] alignment issues when creating accessible forms #8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slavab89 opened this issue Sep 13, 2017 · 2 comments
Closed

[Form Styling] alignment issues when creating accessible forms #8173

slavab89 opened this issue Sep 13, 2017 · 2 comments
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@slavab89
Copy link
Contributor

When creating forms, the recommendation for accessability is to use the rules defined at w3 site here
When using a legend component for Selection Controls it creates a default 2px padding (browser definition). When combined with other form components it creates a non aligned structure.

See the following example and compare "Gender" text against the components of Text Field (Helper text), "Gender" and the radio buttons themselves are padded by 2px
https://codesandbox.io/s/j4zvvx0x4v

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work v1 good first issue Great for first contributions. Enable to learn the contribution process. labels Sep 13, 2017
@oliviertassinari
Copy link
Member

Thanks for opening the issue. It should be a one line change fix. We can set the padding to zero. Do you want to give it a shot?

@oliviertassinari oliviertassinari added new feature New feature or request and removed bug 🐛 Something doesn't work labels Sep 13, 2017
@slavab89
Copy link
Contributor Author

Yep 😄 (I'll do it later today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants