-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[docs] Fix typing errors in Rating component migration guide #45792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for creating a pull request to address this issue! It's common for new contributors to face challenges with the CI process. Regarding labels: Contributors typically don't need to add labels themselves - the repository maintainers will review your PR and add appropriate labels. So don't worry about that part. For the CI verification failures, try running these commands locally to identify and fix the issues:
Run these in the project root directory after installing dependencies. Each command should point you to specific issues that need fixing. Fix these locally, commit the changes, and push to your PR branch to trigger a new CI run. If you'd like help with the specific CI errors, you could share the error details and I or someone else in the community might be able to help you resolve them. Keep in mind that the Material UI team has specific contribution guidelines, so it might be worth checking their contributing documentation if you haven't already. Don't be discouraged by initial setbacks - contributing to open source often involves a learning curve, and your efforts to fix this issue are appreciated! |
@WinnieS0728 Label's will be added by maintainers, you need to worry about. If you wish to open PR again, please feel free to do it. Do note that there are unrelated changes in your closed PR, remove those and re-open PR |
@Kartik-Murthy @sai6855 thanks for helping me. I'm not in office this week. and I notice my unrelated changes. I can record my screen in next comment next week when I'm in office. |
@sai6855 I notice you have fixed the type issue. thank you very much. 2025-04-07.9.32.10.mp4I'm using cursor IDE, I don't know why this happened. |
@WinnieS0728 Okay, I'm not much familiar with cursor, so i'm not able to comment why it's causing the issue. |
This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. |
I created a pull request #45791 but I don't know how to create a label.
I got fail when ci verify.
so I create this Issue.
Issue Description
Found documentation typing errors related to Rating component migration guide.
1. Migration Guide Error
Location: Migrating from deprecated APIs
Current:
Should be:
2. Codemod README Error
Location: codemod readme
Component name
Current
Should be:
command
Current
Should be
Your environment
npx @mui/envinfo
Search keywords: doc v6 migration codemod rating-prop
The text was updated successfully, but these errors were encountered: