Skip to content

[material-ui] Autocomplete right click triggers open #36075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
sp-reach opened this issue Feb 6, 2023 · 7 comments · May be fixed by #36389
Open
2 tasks done

[material-ui] Autocomplete right click triggers open #36075

sp-reach opened this issue Feb 6, 2023 · 7 comments · May be fixed by #36389
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material

Comments

@sp-reach
Copy link

sp-reach commented Feb 6, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:
https://mui.com/material-ui/react-autocomplete/

Steps:

  1. Scroll to first Autocomplete example
  2. right click item

Current behavior 😯

Right clicking the component renders the "opened" state of the list.

Expected behavior 🤔

Right click doesn't trigger an "onclick" event which opens the list.

Context 🔦

Right clicking is a native browser and OS system, which we shouldn't typically be listening to, especially on a search component.

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@sp-reach sp-reach added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 6, 2023
@zannager zannager added the component: autocomplete This is the name of the generic UI component, not the React module! label Feb 6, 2023
@michaldudak
Copy link
Member

Thanks for pointing this out. I'm afraid we can't change this behavior now, as there may be applications that depend on it, but we'll consider it for the upcoming major release.

@michaldudak michaldudak added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 6, 2023
@michaldudak michaldudak added this to the v6 milestone Feb 6, 2023
@michaldudak michaldudak removed their assignment Feb 6, 2023
@taverasady
Copy link

Thanks for pointing this out. I'm afraid we can't change this behavior now, as there may be applications that depend on it, but we'll consider it for the upcoming major release.

@michaldudak can I fix this, create the PR and then it can be merged whenever the "major releasse" is deployed?

@michaldudak
Copy link
Member

It may require some more work before we merge it (to resolve conflicts that may appear in the meantime), but sure, feel free to do it.

@taverasady
Copy link

It may require some more work before we merge it (to resolve conflicts that may appear in the meantime), but sure, feel free to do it.

i have an open PR awaiting for your review/approval click here

@shraddhadev24
Copy link

@michaldudak looks like this issue is pending and PR require changes from a long time back, Can I take this up ?

@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Dec 1, 2023
@danilo-leal danilo-leal changed the title Autocomplete right click triggers open [material-ui] Autocomplete right click triggers open Dec 1, 2023
@mj12albert
Copy link
Member

Could this one be v6? @DiegoAndai

@DiegoAndai
Copy link
Member

@mj12albert, I would keep it planned for v7 until we know all the zero-runtime breaking changes. If these breaking changes are few, we might add this one back to v6. Does that make sense to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

9 participants