-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[material-ui][Menu] Update icons to behave consistently in light & dark mode #35589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@gerdadesign Even in light mode, I could not see lesser opacity getting applied for icons while in Recording_1672051808115.webmOr am I checking in a wrong way? I use Windows OS. |
@ZeeshanTamboli You're correct. I've updated the description. There is lower opacity in our disabled/inactive state, but we do not change opacity for focused. Furthermore, our dark primary text is at 100% #FFF while Material (MD2) lists it at 87%. MD3 also uses slightly off white and off black color values. It seems there are a few options:
|
Duplicates
Latest version
Steps to reproduce 🕹
Link to live example:
Current icon menu: https://mui.com/material-ui/react-menu/#icon-menu in dark mode
Current behavior 😯
Light mode:
Active + unfocused icons are at 54% opacity
Active + focused icons do not change
Dark mode:
Active + unfocused icons are at 100% opacity
Active + focused icons do not change
Expected behavior 🤔
Material Design 2 guidelines for light and dark mode indicated that active + unfocused in dark mode should be at 70% opacity.

Noting that Material Design 3 handles this differently and does not change the icon color upon focus. They opt for outlined vs filled icons in many examples.
Context 🔦
#6619 comment
Your environment 🌎
No response
The text was updated successfully, but these errors were encountered: