-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
React v17 lighthouse passive events #22252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ilanbm Please provide a minimal reproduction test case. This would help a lot 👷 . |
A duplicate of #13623 (comment)? |
I have run a lighthouse run on https://next--material-ui.netlify.app/components/buttons/, the latest version, we comply to the rule: I'm closing, we need a reproduction. |
A reproduction https://codesandbox.io/s/6kw4d (deployed on https://csb-6kw4d.netlify.app/) with React 17. See #22269 (comment) for a bit more context. |
My understanding of the situation so far: facebook/react#6436 (comment). |
I found that it only happens when using react@experimental , with react 16.13.1 it doesn't happen |
Just read about React v17 event delegation, is there a way to set the root element to be passive? |
Let's reduce this to a reproduction without any Material-UI components and then illustrate our use case. With those two code samples we can open an issue in the React repo. This will reduce the time it takes for a core member to respond. |
@eps1lon done, turned into facebook/react#19651 |
Solved in facebook/react#19651 |
Running Lighthouse on pages with Button component get "Does not use passive listeners to improve scrolling performance"
"Consider marking your touch and wheel event listeners as
passive
to improve your page's scroll performance"https://web.dev/uses-passive-event-listeners/?utm_source=lighthouse&utm_medium=devtools
Current Behavior 😯
Expected Behavior 🤔
Steps to Reproduce 🕹
Steps:
Context 🔦
Your Environment 🌎
The text was updated successfully, but these errors were encountered: