Skip to content

Commit d6cac35

Browse files
committed
Improve TODO v6 comments
1 parent 3dc2dc2 commit d6cac35

File tree

6 files changed

+20
-10
lines changed

6 files changed

+20
-10
lines changed

packages/mui-material-next/src/Select/Select.d.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import * as React from 'react';
22
import { SxProps } from '@mui/system';
3-
// TODO v6: replace @mui/material with @mui/material-next when components are available
3+
// TODO v6: replace material Theme with material-next Theme when Material You design is implemented
44
import { InternalStandardProps as StandardProps, Theme } from '@mui/material';
5+
// TODO v6: replace with material-next Input components props https://github.com/mui/material-ui/pull/39188#discussion_r1339645381
56
import { InputProps } from '@mui/material/Input';
7+
// TODO v6: replace with material-next Menu https://github.com/mui/material-ui/pull/38934
68
import { MenuProps } from '@mui/material/Menu';
9+
// TODO v6: replace with material-next OutlinedInput when available
710
import { OutlinedInputProps } from '@mui/material/OutlinedInput';
811
import { SelectChangeEvent, SelectInputProps } from './SelectInput';
912
import { SelectClasses } from './selectClasses';

packages/mui-material-next/src/Select/Select.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ import * as React from 'react';
33
import PropTypes from 'prop-types';
44
import clsx from 'clsx';
55
import { deepmerge, unstable_useForkRef as useForkRef } from '@mui/utils';
6-
// TODO v6: replace @mui/material with @mui/material-next when components are available
7-
import Input from '@mui/material/Input';
86
import NativeSelectInput from '@mui/material/NativeSelect/NativeSelectInput';
7+
// TODO v6: Remove Input component after implementing Material You design
8+
import Input from '@mui/material/Input';
9+
// TODO v6: replace with material-next FilledInput when available https://github.com/mui/material-ui/issues/39052
910
import FilledInput from '@mui/material/FilledInput';
11+
// TODO v6: replace with material-next OutlinedInput when available
1012
import OutlinedInput from '@mui/material/OutlinedInput';
1113
import SelectInput from './SelectInput';
1214
import formControlState from '../FormControl/formControlState';

packages/mui-material-next/src/Select/Select.spec.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
2-
// TODO v6: replace @mui/material with @mui/material-next when Menu component is available
2+
// TODO v6: replace with material-next Menu when available https://github.com/mui/material-ui/pull/38934
33
import MenuItem from '@mui/material/MenuItem';
4-
// TODO v6: replace createTheme with material-next's extendTheme when implementing Material You design
4+
// TODO v6: replace with material-next's extendTheme when implementing Material You design
55
import { createTheme } from '@mui/material/styles';
66
import Select, { SelectChangeEvent } from '@mui/material-next/Select';
77

packages/mui-material-next/src/Select/Select.test.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,18 @@ import {
99
fireEvent,
1010
screen,
1111
} from '@mui-internal/test-utils';
12+
import { nativeSelectClasses } from '@mui/material/NativeSelect';
13+
// TODO v6: replace with material-next's extendTheme and provider when implementing Material You design
1214
import { createTheme, ThemeProvider } from '@mui/material/styles';
15+
// TODO v6: replace with material-next Menu components when available https://github.com/mui/material-ui/pull/38934
1316
import MenuItem, { menuItemClasses } from '@mui/material/MenuItem';
14-
// TODO v6: replace @mui/material with @mui/material-next when components are available
17+
// TODO v6: replace with material-next ListSubheader when available
1518
import ListSubheader from '@mui/material/ListSubheader';
19+
// TODO v6: replace with material-next OutlinedInput when available
1620
import OutlinedInput from '@mui/material/OutlinedInput';
21+
// TODO v6: replace with material-next InputLabel when available
1722
import InputLabel from '@mui/material/InputLabel';
18-
import { nativeSelectClasses } from '@mui/material/NativeSelect';
23+
// TODO v6: replace with material-next Divider when available
1924
import Divider from '@mui/material/Divider';
2025
import Select from '@mui/material-next/Select';
2126
import classes from './selectClasses';

packages/mui-material-next/src/Select/SelectInput.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22
import { SxProps } from '@mui/system';
3-
// TODO v6: replace @mui/material with @mui/material-next when Menu component is available
3+
// TODO v6: replace with material-next MenuProps when available https://github.com/mui/material-ui/pull/38934
44
import { MenuProps } from '@mui/material/Menu';
55
import { Theme } from '..';
66

packages/mui-material-next/src/Select/SelectInput.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ import {
1414
unstable_useControlled as useControlled,
1515
} from '@mui/utils';
1616
import { shouldForwardProp } from '@mui/system';
17-
// TODO v6: replace @mui/material with @mui/material-next when components are available
18-
import Menu from '@mui/material/Menu/Menu';
1917
import {
2018
nativeSelectSelectStyles,
2119
nativeSelectIconStyles,
2220
} from '@mui/material/NativeSelect/NativeSelectInput';
21+
// TODO v6: replace with material-next Menu component when available https://github.com/mui/material-ui/pull/38934
22+
import Menu from '@mui/material/Menu/Menu';
2323
import { isFilled } from '../InputBase/utils';
2424
import styled from '../styles/styled';
2525
import selectClasses, { getSelectUtilityClasses } from './selectClasses';

0 commit comments

Comments
 (0)