[core] Update scripts to support base-ui (#45784)

Co-authored-by: Brijesh Bittu <[email protected]>

Author: brijeshb42

.eslintrc.js

@@ -64,7 +64,7 @@ module.exports = /** @type {Config} */ ({
     'plugin:eslint-plugin-import/recommended',
     'plugin:eslint-plugin-import/typescript',
     'eslint-config-airbnb',
-    './eslint/config-airbnb-typescript.js',
+    require.resolve('./eslint/config-airbnb-typescript.js'),
     'eslint-config-prettier',
   ],
   parser: '@typescript-eslint/parser',

package.json

@@ -174,6 +174,7 @@
     "fast-glob": "^3.3.3",
     "fs-extra": "^11.3.0",
     "globby": "^14.1.0",
+    "jsonc-parser": "^3.3.1",
     "karma": "^6.4.4",
     "karma-browserstack-launcher": "~1.6.0",
     "karma-chrome-launcher": "^3.2.0",

pnpm-lock.yaml

@@ -17,8 +17,14 @@ const validBundles = [
   'stable',
 ];
 
+const bundleTypes = {
+  modern: 'module',
+  stable: 'module',
+  node: 'commonjs',
+};
+
 async function run(argv) {
-  const { bundle, largeFiles, outDir: outDirBase, verbose } = argv;
+  const { bundle, largeFiles, outDir: outDirBase, verbose, cjsDir } = argv;
 
   if (!validBundles.includes(bundle)) {
     throw new TypeError(
@@ -53,7 +59,7 @@ async function run(argv) {
   const outFileExtension = '.js';
 
   const relativeOutDir = {
-    node: './',
+    node: cjsDir,
     modern: './modern',
     stable: './esm',
   }[bundle];
@@ -107,12 +113,15 @@ async function run(argv) {
   // `--extensions-.cjs --out-file-extension .cjs`
   await cjsCopy({ from: srcDir, to: outDir });
 
-  const isEsm = bundle === 'modern' || bundle === 'stable';
-  if (isEsm && !argv.skipEsmPkg) {
+  // Write a package.json file in the output directory if we are building the modern or stable bundle
+  // or if the output directory is not the root of the package.
+  const shouldWriteBundlePackageJson =
+    bundle === 'modern' || bundle === 'stable' || relativeOutDir !== './';
+  if (shouldWriteBundlePackageJson && !argv.skipEsmPkg) {
     const rootBundlePackageJson = path.join(outDir, 'package.json');
     await fs.writeFile(
       rootBundlePackageJson,
-      JSON.stringify({ type: 'module', sideEffects: packageJson.sideEffects }),
+      JSON.stringify({ type: bundleTypes[bundle], sideEffects: packageJson.sideEffects }),
     );
   }
 
@@ -143,6 +152,11 @@ yargs(process.argv.slice(2))
           describe:
             "Set to `true` if you don't want to generate a package.json file in the /esm folder.",
         })
+        .option('cjsDir', {
+          default: './',
+          type: 'string',
+          description: 'The directory to copy the cjs files to.',
+        })
         .option('out-dir', { default: './build', type: 'string' })
         .option('verbose', { type: 'boolean' });
     },

scripts/build.mjs

@@ -4,15 +4,18 @@ import path from 'path';
 import yargs from 'yargs';
 import { $ } from 'execa';
 import * as babel from '@babel/core';
+import { parse } from 'jsonc-parser';
 
 const $$ = $({ stdio: 'inherit' });
 
 async function emitDeclarations(tsconfig: string, outDir: string) {
+  // eslint-disable-next-line no-console
   console.log(`Building types for ${path.resolve(tsconfig)}`);
   await $$`tsc -p ${tsconfig} --outDir ${outDir} --declaration --emitDeclarationOnly`;
 }
 
 async function addImportExtensions(folder: string) {
+  // eslint-disable-next-line no-console
   console.log(`Adding import extensions`);
   const dtsFiles = await glob('**/*.d.ts', { absolute: true, cwd: folder });
   if (dtsFiles.length === 0) {
@@ -42,6 +45,7 @@ async function copyDeclarations(sourceDirectory: string, destinationDirectory: s
   const fullSourceDirectory = path.resolve(sourceDirectory);
   const fullDestinationDirectory = path.resolve(destinationDirectory);
 
+  // eslint-disable-next-line no-console
   console.log(`Copying declarations from ${fullSourceDirectory} to ${fullDestinationDirectory}`);
 
   await fs.cp(fullSourceDirectory, fullDestinationDirectory, {
@@ -62,25 +66,30 @@ async function copyDeclarations(sourceDirectory: string, destinationDirectory: s
 
 interface HandlerArgv {
   skipTsc: boolean;
+  copy: string[];
 }
 
 async function main(argv: HandlerArgv) {
   const packageRoot = process.cwd();
+  const tsconfigPath = path.join(packageRoot, 'tsconfig.build.json');
+  const tsconfigExists = await fs.access(tsconfigPath).then(
+    () => true,
+    () => false,
+  );
+
+  const tsConfig = tsconfigExists
+    ? (parse(await fs.readFile(tsconfigPath, 'utf-8')) as { compilerOptions: { outDir: string } })
+    : null;
 
   const srcPath = path.join(packageRoot, 'src');
   const buildFolder = path.join(packageRoot, 'build');
-  const esmFolder = path.join(buildFolder, 'esm');
-  const modernFolder = path.join(buildFolder, 'modern');
+  const esmOrOutDir = tsConfig?.compilerOptions.outDir
+    ? path.join(packageRoot, tsConfig.compilerOptions.outDir)
+    : path.join(buildFolder, 'esm');
 
-  await copyDeclarations(srcPath, esmFolder);
+  await copyDeclarations(srcPath, esmOrOutDir);
 
   if (!argv.skipTsc) {
-    const tsconfigPath = path.join(packageRoot, 'tsconfig.build.json');
-    const tsconfigExists = await fs.access(tsconfigPath).then(
-      () => true,
-      () => false,
-    );
-
     if (!tsconfigExists) {
       throw new Error(
         'Unable to find a tsconfig to build this project. ' +
@@ -89,29 +98,36 @@ async function main(argv: HandlerArgv) {
       );
     }
 
-    await emitDeclarations(tsconfigPath, esmFolder);
+    await emitDeclarations(tsconfigPath, esmOrOutDir);
   }
 
-  await addImportExtensions(esmFolder);
+  await addImportExtensions(esmOrOutDir);
 
-  await copyDeclarations(esmFolder, buildFolder);
-  await copyDeclarations(esmFolder, modernFolder);
+  await Promise.all(
+    argv.copy.map((copy) => copyDeclarations(esmOrOutDir, path.join(packageRoot, copy))),
+  );
 }
 
 yargs(process.argv.slice(2))
-  .command<HandlerArgv>({
-    command: '$0',
-    description:
-      'Builds a project with a fix for https://github.com/microsoft/TypeScript/issues/39117',
-    builder: (command) => {
-      return command.option('skipTsc', {
-        type: 'boolean',
-        default: false,
-        describe: 'Set to `true` if you want the legacy behavior of just copying .d.ts files.',
-      });
+  .command<HandlerArgv>(
+    '$0',
+    'Builds type definition files and copies them to the specified directories with a fix for https://github.com/microsoft/TypeScript/issues/39117',
+    (command) => {
+      return command
+        .option('skipTsc', {
+          type: 'boolean',
+          default: false,
+          describe: 'Set to `true` if you want the legacy behavior of just copying .d.ts files.',
+        })
+        .option('copy', {
+          alias: 'c',
+          type: 'array',
+          description: 'Directories where the type definition files should be copied',
+          default: ['build', 'build/modern'],
+        });
     },
-    handler: main,
-  })
+    main,
+  )
   .help()
   .strict(true)
   .version(false)

scripts/buildTypes.mts

@@ -1,11 +1,33 @@
 import path from 'path';
 import url from 'url';
+import fs from 'fs';
+
+function findUpFile(fileName, cwd = process.cwd(), maxIterations = 5) {
+  const pathName = path.join(cwd, fileName);
+  if (fs.existsSync(pathName)) {
+    return pathName;
+  }
+  if (maxIterations === 0) {
+    return null;
+  }
+  return findUpFile(fileName, path.dirname(cwd), maxIterations - 1);
+}
 
 /**
- * Returns the full path of the root directory of this repository.
+ * Returns the full path of the root directory of the monorepo.
  */
 // eslint-disable-next-line import/prefer-default-export
 export function getWorkspaceRoot() {
+  // Use this when available. Avoids the need to check for the workspace file.
+  if (process.env.NX_WORKSPACE_ROOT) {
+    return process.env.NX_WORKSPACE_ROOT;
+  }
+
+  const workspaceFilePath = findUpFile('pnpm-workspace.yaml', process.cwd());
+  if (workspaceFilePath) {
+    return path.dirname(workspaceFilePath);
+  }
+
   const currentDirectory = url.fileURLToPath(new URL('.', import.meta.url));
   const workspaceRoot = path.resolve(currentDirectory, '..');
   return workspaceRoot;