Skip to content

Commit 2d2905d

Browse files
committed
Fix component prop and tests
1 parent 50c04aa commit 2d2905d

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

packages/mui-material-next/src/FormControl/FormControl.test.js

+4
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { describeConformance, act, createRenderer, fireEvent } from '@mui-intern
55
import FormControl, { formControlClasses as classes } from '@mui/material-next/FormControl';
66
// TODO v6: replace with material-next/FilledInput
77
import InputBase from '@mui/material-next/InputBase';
8+
import { CssVarsProvider, extendTheme } from '@mui/material-next/styles';
89
// TODO v6: replace with material-next/Select
910
import Select from '@mui/material/Select';
1011
import useFormControl from './useFormControl';
@@ -23,6 +24,8 @@ describe('<FormControl />', () => {
2324
describeConformance(<FormControl />, () => ({
2425
classes,
2526
inheritComponent: 'div',
27+
ThemeProvider: CssVarsProvider,
28+
createTheme: extendTheme,
2629
render,
2730
refInstanceof: window.HTMLDivElement,
2831
muiName: 'MuiFormControl',
@@ -32,6 +35,7 @@ describe('<FormControl />', () => {
3235
testWithElement: 'fieldset',
3336
},
3437
},
38+
testRootOverrides: { slotName: 'root', slotClassName: classes.root },
3539
testComponentPropWith: 'fieldset',
3640
testVariantProps: { margin: 'dense' },
3741
skip: ['componentsProp'],

packages/mui-material-next/src/FormControl/FormControl.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const FormControl = React.forwardRef(function FormControl<
9090
className,
9191
classes: classesProp,
9292
color = 'primary',
93-
component: ComponentProp = 'div',
93+
component: componentProp,
9494
disabled = false,
9595
error = false,
9696
focused: visuallyFocused,
@@ -184,7 +184,7 @@ const FormControl = React.forwardRef(function FormControl<
184184
...props,
185185
classes: props.classes ?? {},
186186
color,
187-
component: ComponentProp,
187+
component: componentProp,
188188
disabled,
189189
error,
190190
filled,
@@ -242,13 +242,14 @@ const FormControl = React.forwardRef(function FormControl<
242242
variant,
243243
]);
244244

245-
const Root = slots.root ?? ComponentProp ?? FormControlRoot;
245+
const Root = slots.root ?? FormControlRoot;
246246
const rootProps = useSlotProps({
247247
elementType: Root,
248248
externalSlotProps: slotProps.root,
249249
externalForwardedProps: other,
250250
additionalProps: {
251251
ref: forwardedRef,
252+
as: componentProp,
252253
},
253254
ownerState,
254255
className: [classes.root, className],

0 commit comments

Comments
 (0)