[core] Replace hoistMuiStatics usages (#14722)

The whole community is using hoist-non-react-statics, let's go for it. We should be able to remove the yarn version lock at some point.

*This change is taken from #14560 as an effort not to merge too big pull requests.*

Author: oliviertassinari

packages/material-ui-icons/builder.js

@@ -168,7 +168,7 @@ async function main(options) {
 
     let renameFilter = options.renameFilter;
     if (typeof renameFilter === 'string') {
-      /* eslint-disable-next-line global-require, import/no-dynamic-require */
+      // eslint-disable-next-line global-require, import/no-dynamic-require
       renameFilter = require(renameFilter).default;
     }
     if (typeof renameFilter !== 'function') {

packages/material-ui-styles/src/withStyles.js

@@ -1,7 +1,8 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import warning from 'warning';
-import { getDisplayName, hoistMuiStatics } from '@material-ui/utils';
+import hoistNonReactStatics from 'hoist-non-react-statics';
+import { getDisplayName } from '@material-ui/utils';
 import makeStyles from './makeStyles';
 import RefHolder from './RefHolder';
 import getThemeProps from './getThemeProps';
@@ -88,7 +89,7 @@ const withStyles = (stylesOrCreator, options = {}) => Component => {
     WithStyles.displayName = `WithStyles(${getDisplayName(Component)})`;
   }
 
-  hoistMuiStatics(WithStyles, Component);
+  hoistNonReactStatics(WithStyles, Component);
 
   return WithStyles;
 };

packages/material-ui-styles/src/withStyles.test.js

@@ -22,11 +22,11 @@ describe('withStyles', () => {
     mount.cleanUp();
   });
 
-  it('does not hoist statics', () => {
+  it('hoist statics', () => {
     const Test = () => null;
     Test.someStatic = 'will not get hoisted';
     const TestWithStyles = withStyles({})(Test);
-    assert.strictEqual(TestWithStyles.someStatic, undefined);
+    assert.strictEqual(TestWithStyles.someStatic, Test.someStatic);
   });
 
   it('hoists mui internals', () => {

packages/material-ui-styles/src/withTheme.js

@@ -1,6 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { getDisplayName, hoistMuiStatics } from '@material-ui/utils';
+import hoistNonReactStatics from 'hoist-non-react-statics';
+import { getDisplayName } from '@material-ui/utils';
 import useTheme from './useTheme';
 import RefHolder from './RefHolder';
 
@@ -38,7 +39,7 @@ const withTheme = Component => {
     WithTheme.displayName = `WithTheme(${getDisplayName(Component)})`;
   }
 
-  hoistMuiStatics(WithTheme, Component);
+  hoistNonReactStatics(WithTheme, Component);
 
   return WithTheme;
 };

packages/material-ui-styles/src/withTheme.test.js

@@ -37,11 +37,11 @@ describe('withTheme', () => {
     assert.strictEqual(wrapper.text(), 'foo');
   });
 
-  it('does not hoist statics', () => {
+  it('hoist statics', () => {
     const Test = () => null;
     Test.someStatic = 'will not get hoisted';
     const TestWithTheme = withTheme(Test);
-    assert.strictEqual(TestWithTheme.someStatic, undefined);
+    assert.strictEqual(TestWithTheme.someStatic, Test.someStatic);
   });
 
   it('hoists mui internals', () => {

packages/material-ui-utils/src/hoistMuiStatics.js

@@ -1,5 +1,4 @@
 export { default as chainPropTypes } from './chainPropTypes';
 export { default as exactProp } from './exactProp';
 export { default as getDisplayName } from './getDisplayName';
-export { default as hoistMuiStatics } from './hoistMuiStatics';
 export { default as ponyfillGlobal } from './ponyfillGlobal';

packages/material-ui-utils/src/index.js

@@ -239,7 +239,7 @@ describe('<InputBase />', () => {
 
     beforeEach(() => {
       // we need a class for enzyme otherwise: "Can't call ::setState on functional component"
-      /* eslint-disable-next-line react/prefer-stateless-function */
+      // eslint-disable-next-line react/prefer-stateless-function
       class Provider extends React.Component {
         render() {
           const { context, ...other } = this.props;

packages/material-ui/src/InputBase/InputBase.test.js

@@ -1,5 +1,6 @@
 import React from 'react';
-import { getDisplayName, hoistMuiStatics } from '@material-ui/utils';
+import hoistNonReactStatics from 'hoist-non-react-statics';
+import { getDisplayName } from '@material-ui/utils';
 
 /**
  * Enables ref forwarding on a given component that uses `innerRef` to forward refs
@@ -28,5 +29,5 @@ export default function withForwardedRef(Component) {
     ForwardRefComponent.displayName = `ForwardRef(${getDisplayName(Component)})`;
   }
 
-  return hoistMuiStatics(ForwardRefComponent, Component);
+  return hoistNonReactStatics(ForwardRefComponent, Component);
 }