Skip to content

[Switch] Integrate with FormControlUnstyled #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaldudak opened this issue Mar 31, 2022 · 3 comments
Closed

[Switch] Integrate with FormControlUnstyled #13

michaldudak opened this issue Mar 31, 2022 · 3 comments
Labels
component: switch This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@michaldudak
Copy link
Member

Make SwitchUnstyled aware of the FormControlUnstyled context, similarly to how Material UI's Switch interacts with FormControl.
@EduardoSCosta
Copy link

Hi, I'd like to do this issue 😃

@michaldudak
Copy link
Member Author

Hi. It requires #14 to be completed first (or adding a second parameter, newValue, to all inputs' onChange events), so that FormControlUnstyled is able is figure out the new value after it changes.

@mnajdova mnajdova changed the title [SwitchUnstyled] Integrate with FormControlUnstyled [base][Switch] Integrate with FormControlUnstyled Apr 17, 2023
@mj12albert mj12albert mentioned this issue May 18, 2023
Closed
7 tasks
@michaldudak michaldudak changed the title [base][Switch] Integrate with FormControlUnstyled [Switch][base-ui] Integrate with FormControlUnstyled Aug 18, 2023
@michaldudak michaldudak transferred this issue from mui/material-ui Feb 27, 2024
@michaldudak michaldudak changed the title [Switch][base-ui] Integrate with FormControlUnstyled [Switch] Integrate with FormControlUnstyled Feb 27, 2024
@michaldudak michaldudak added enhancement This is not a bug, nor a new feature component: switch This is the name of the generic UI component, not the React module! labels Feb 27, 2024
@michaldudak
Copy link
Member Author

We replaced FormControlUnstyled with Form and Field components. The Switch does support them out of the box.

@michaldudak michaldudak closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Base UI public roadmap Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: switch This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
Base UI public roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaldudak @EduardoSCosta