Skip to content

Commit 278eb57

Browse files
authored
Merge pull request #8105 from NBKelly/graphics-for-picking-card-backs
display graphics when selecting card backs
2 parents 5271fb7 + ac43330 commit 278eb57

File tree

3 files changed

+35
-10
lines changed

3 files changed

+35
-10
lines changed

src/cljc/jinteki/card_backs.cljc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@
1919
card-backs))
2020

2121
(defn card-backs-for-side [side unlocked]
22-
(into {} (filter (fn [[k v]]
22+
;; TODO for later - explicitly make the nsg and ffg backs pop up at the top of the list,
23+
;; regardless of the sorting used
24+
(into (sorted-map-by (fn [k1 k2]
25+
(compare [(get-in card-backs [k1 :name]) k1]
26+
[(get-in card-backs [k2 :name]) k2])))
27+
(filter (fn [[k v]]
2328
(and
2429
;; it either has no specified side, or matches the input side
2530
(or (not (:side v)) (= side (:side v)))

src/cljs/nr/account.cljs

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -521,22 +521,41 @@
521521

522522
[:section
523523
[:h3 (tr [:settings_corp-card-sleeve "Corp card backs"])]
524-
[:select {:value (:corp-card-sleeve @s "nsg")
525-
:on-change #(swap! s assoc :corp-card-sleeve (.. % -target -value))}
524+
[:select {:value (:corp-card-sleeve @s "nsg-card-back")
525+
:on-change #(swap! s assoc :corp-card-sleeve (or (.. % -target -value) "nsg-card-back"))}
526526
(doall
527527
(for [[k v] (card-backs/card-backs-for-side :corp (-> @s :prizes :card-backs))]
528528
[:option {:value k :key k}
529529
(tr [(keyword (str "card-backs_" k)) (:name v)])]))]
530530

531-
;; [:section
531+
532532
[:h3 (tr [:settings_runner-card-sleeve "Runner card backs"])]
533-
[:select {:value (:runner-card-sleeve @s "nsg")
534-
:on-change #(swap! s assoc :runner-card-sleeve (.. % -target -value))}
533+
[:select {:value (:runner-card-sleeve @s "nsg-card-back")
534+
:on-change #(swap! s assoc :runner-card-sleeve (or (.. % -target -value) "nsg-card-back"))}
535535
(doall
536536
(for [[k v] (card-backs/card-backs-for-side :runner (-> @s :prizes :card-backs))]
537537
[:option {:value k :key k}
538538
(tr [(keyword (str "card-backs_" k)) (:name v)])]))]
539-
[:div "You can earn more card backs by placing well in select online tournaments. If you're an artist with art that you think would make for a good card back, please feel free to contact us"]]
539+
[:div "You can earn more card backs by placing well in select online tournaments. If you're an artist with art that you think would make for a good card back, please feel free to contact us"]
540+
541+
[:div {:style {:display "flex" :justifyContent "center"}}
542+
[:div
543+
{:style {:display "flex" :flexDirection "column" :alighItems "center" :margin "1rem"}}
544+
[:img {:src (str "/img/card-backs/corp/"
545+
(get-in (card-backs/card-backs-for-side :corp (-> @s :prizes :card-backs)) [(keyword (:corp-card-sleeve @s "nsg-card-back")) :file])
546+
".png")
547+
:style {:maxWidth "200px"}
548+
:alt "Corp card back"}]
549+
[:div {:style {:marginTop "0.5rem" :textAlign "center"}} "Corp card back"]]
550+
551+
[:div
552+
{:style {:display "flex" :flexDirection "column" :alighItems "center" :margin "1rem"}}
553+
[:img {:src (str "/img/card-backs/runner/"
554+
(get-in (card-backs/card-backs-for-side :runner (-> @s :prizes :card-backs)) [(keyword (:runner-card-sleeve @s "nsg-card-back")) :file])
555+
".png")
556+
:style {:maxWidth "200px"}
557+
:alt "Runner card back"}]
558+
[:div {:style {:marginTop "0.5rem" :textAlign "center"}} "Runner card back"]]]]
540559

541560
[:section
542561
[:h3 (tr [:settings_card-preview-zoom "Card preview zoom"])]

src/cljs/nr/gameboard/board.cljs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -344,13 +344,14 @@
344344
side-key (keyword (lower-case side))
345345
display-options (or (get-in @app-state [:options :card-back-display]) "them")
346346
card-back (if (= side-key my-side)
347-
(or (get-in @game-state [my-side :user :options (if (= side-key :corp) :corp-card-sleeve :runner-card-sleeve)]) "nsg-card-back")
347+
(get-in @game-state [my-side :user :options (if (= side-key :corp) :corp-card-sleeve :runner-card-sleeve)] "nsg-card-back")
348348
(case display-options
349-
"them" (or (get-in @game-state [side-key :user :options (if (= side-key :corp) :corp-card-sleeve :runner-card-sleeve)]) "nsg-card-back")
350-
"me" (or (get-in @game-state [my-side :user :options (if (= side-key :corp) :corp-card-sleeve :runner-card-sleeve)]) "nsg-card-back")
349+
"them" (get-in @game-state [side-key :user :options (if (= side-key :corp) :corp-card-sleeve :runner-card-sleeve)] "nsg-card-back")
350+
"me" (get-in @game-state [my-side :user :options (if (= side-key :corp) :corp-card-sleeve :runner-card-sleeve)] "nsg-card-back")
351351
"ffg" "ffg-card-back"
352352
"nsg" "nsg-card-back"
353353
"nsg-card-back"))
354+
card-back (if (= card-back "") "nsg-card-back" card-back)
354355
maybe-image? (get-in card-backs/card-backs [(keyword card-back) :file])
355356
s (lower-case side)]
356357
(str "/img/card-backs/" s "/" maybe-image? ".png")))

0 commit comments

Comments
 (0)