Skip to content

Commit e556a81

Browse files
committed
[pretest] update collect_dut_lossless_prio method
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fix method collect_dut_lossless_prio. The pfc_enable parameter can be empty. Without this change we can get error: ``` > result = [int(x) for x in port_qos_map[intf]['pfc_enable'].split(',')] E ValueError: invalid literal for int() with base 10: '' ``` PRs with related changes: sonic-net/sonic-buildimage#22252 sonic-net/sonic-buildimage#22067 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? stable test_pretest.py #### How did you do it? Used method `get` #### How did you verify/test it? Test passed after changes <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
1 parent f48f12f commit e556a81

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/test_pretest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def collect_dut_lossless_prio(dut):
208208

209209
""" Here we assume all the ports have the same lossless priorities """
210210
intf = list(port_qos_map.keys())[0]
211-
if 'pfc_enable' not in port_qos_map[intf]:
211+
if not port_qos_map[intf].get('pfc_enable'):
212212
return []
213213

214214
result = [int(x) for x in port_qos_map[intf]['pfc_enable'].split(',')]

0 commit comments

Comments
 (0)