Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation warning on go to definition hover action (nvim 0.11) #711

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

frolvanya
Copy link
Contributor

I assume that this issue was silent, because we used jump_to_location method instead. Since now this method is deprecated we can see that show_document is never called. The correct location of show_document method is in util

closes #710

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@mrcjkb mrcjkb changed the title fix: show_document method location fix: deprecation warning on go to definition hover action (nvim 0.11) Mar 31, 2025
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Strange that I wasn't getting any deprecation warnings in nightly 🤔

@mrcjkb mrcjkb enabled auto-merge (squash) March 31, 2025 09:09
@mrcjkb mrcjkb disabled auto-merge March 31, 2025 09:09
@mrcjkb mrcjkb enabled auto-merge (squash) March 31, 2025 09:09
@mrcjkb mrcjkb merged commit b1faa06 into mrcjkb:master Mar 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vim.lsp.util.jump_to_location is deprecated
2 participants