Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalDocs command broken in Neovim 0.9 #50

Closed
h0pes opened this issue Nov 11, 2023 · 1 comment · Fixed by #52
Closed

externalDocs command broken in Neovim 0.9 #50

h0pes opened this issue Nov 11, 2023 · 1 comment · Fixed by #52
Assignees
Labels
bug Something isn't working

Comments

@h0pes
Copy link

h0pes commented Nov 11, 2023

Feature description

Somehow on my nvim install neither vim.fn.jobstart({ 'xdg-open', 'https://github.com' }) nor vim.system({ 'xdg-open', 'https://github.com' }) work.

xdg-open works perfectly fine run directly from the terminal with a simple xdg-open https://www.google.com.

I can get it working from nvim as an external command execution with :!xdg-open <url>.

I'm not able to understand how to fix this, but I found that the following command works:
:call jobstart('xdg-open https://www.github.com')

In order to use the open_url(url) function here, would it be possible to add a case to run that command?

I find extremely useful the RunLsp externalDocs feature and I'd really like being able to use it.

By the way I attach the error I get when I try to run the externalDocs command.

Thanks a lot!
2023-11-11_09-16_OpenExternalDocs

@h0pes h0pes added the enhancement New feature or request label Nov 11, 2023
@mrcjkb mrcjkb added bug Something isn't working and removed enhancement New feature or request labels Nov 11, 2023
@mrcjkb mrcjkb self-assigned this Nov 11, 2023
@mrcjkb
Copy link
Owner

mrcjkb commented Nov 11, 2023

Hey 👋

Thanks for reporting. That's actually a bug in this plugin - it's using a Neovim function that isn't available in Neovim 0.9 yet.
I'll fix that now...

@mrcjkb mrcjkb linked a pull request Nov 11, 2023 that will close this issue
@mrcjkb mrcjkb changed the title Add call jobstart to open_url function open_url function broken in Neovim 0.9 Nov 11, 2023
@mrcjkb mrcjkb changed the title open_url function broken in Neovim 0.9 externalDocs command broken in Neovim 0.9 Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants