Skip to content

[Bug]: Intermittent failure in the "must work properly when selecting undo by keyboard" integration test #19872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timvandermeij opened this issue Apr 26, 2025 · 1 comment · Fixed by #19873
Assignees

Comments

@timvandermeij
Copy link
Contributor

Attach (recommended) or Link to PDF file

N/A

Web browser and its version

Firefox 137.0.2

Operating system and its version

Arch Linux

PDF.js version

5.1.91

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

I have found that this integration test is one of the most common remaining intermittents now. The most recent occurrence is in #19869. From http://54.241.84.105:8877/ac1262cf22c74ac/output.txt:

1) Highlight Editor Undo deletion popup has the expected behaviour must work properly when selecting undo by keyboard
  Message:
�[31m    ProtocolError: script.callFunction timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.�[0m
  Stack:
        at <instance_members_initializer> (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:97:14)
        at new Callback (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:101:16)
        at CallbackRegistry.create (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:20:26)
        at BidiConnection.send (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/Connection.js:51:32)
        at Session.send (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/core/Session.js:134:42)
        at Session.<anonymous> (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/util/decorators.js:101:27)
        at WindowRealm.callFunction (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/core/Realm.js:92:51)
        at WindowRealm.<anonymous> (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/util/decorators.js:101:27)
        at #evaluate (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/Realm.js:134:42)
        at BidiFrameRealm.evaluateHandle (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/ac1262cf22c74ac/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/Realm.js:101:36)

What is the expected behavior?

The integration test should pass consistently.

What went wrong?

The integration test fails intermittently.

Link to a viewer

No response

Additional context

No response

@timvandermeij
Copy link
Contributor Author

I have debugged this test in #19870 since I wasn't able to make the test fail locally, and thanks to #19870 (comment) found out that the test hangs at https://github.com/mozilla/pdf.js/blob/master/test/integration/highlight_editor_spec.mjs#L2566. This shows that the undo button press didn't work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant